Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2011593002: Make RunApplication() return a MojoResult and TerminateApplication() take one. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make RunApplication() return a MojoResult and TerminateApplication() take one. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/276d65ded4b4db98f90b751596e8c1e364de517f

Patch Set 1 #

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -32 lines) Patch
M examples/spinning_cube/spinning_cube_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/cpp/application/lib/run_application.cc View 1 2 chunks +70 lines, -5 lines 0 comments Download
M mojo/public/cpp/application/run_application.h View 2 chunks +11 lines, -13 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/cpp/utility/lib/run_loop.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/log/cpp/log_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M services/test_service/test_request_tracker_application.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/test_service/test_service_application.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-24 19:48:43 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-24 21:05:51 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-24 21:19:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
276d65ded4b4db98f90b751596e8c1e364de517f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698