Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2008543004: Add RunMainApplication()/TerminateMainApplication() for use in MojoMain(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work796_run_app_returns
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add RunMainApplication()/TerminateMainApplication() for use in MojoMain(). Move run_application.h to //mojo/public/cpp/application:application. To do (separately): Provide an implementation of run_application.h in the "chromium" implementation. (Now that there are "main" versions of these, we can.) This will allow more code to be converted to use ApplicationImplBase, etc. (instead of ApplicationDelegate and ApplicationRunner[Chromium]). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/50399142344d03be48aafbece8018fd97a74b1d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M examples/spinning_cube/spinning_cube_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/run_application.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/run_application.h View 1 chunk +18 lines, -16 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/log/cpp/log_client.h View 1 chunk +1 line, -1 line 0 comments Download
M services/test_service/test_request_tracker_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/test_service/test_service_application.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/2011593002/.
4 years, 7 months ago (2016-05-24 20:51:01 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-24 21:24:05 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-24 21:54:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50399142344d03be48aafbece8018fd97a74b1d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698