Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 201153021: cc: Apply occlusion before creating quads in TextureLayerImpl. (Closed)

Created:
6 years, 9 months ago by danakj
Modified:
6 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman
Visibility:
Public.

Description

cc: Apply occlusion before creating quads in TextureLayerImpl. This makes the AppendQuads method query occlusion directly and subtract it from the quads it would create before they are created, skipping quads that are completely occluded and avoiding a malloc/free for them. R=enne@chromium.org, enne BUG=344962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258146

Patch Set 1 #

Patch Set 2 : append-texture: #

Total comments: 1

Patch Set 3 : append-texture: year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -61 lines) Patch
M cc/cc_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/io_surface_layer_impl_unittest.cc View 1 3 chunks +15 lines, -28 lines 0 comments Download
M cc/layers/solid_color_layer_impl_unittest.cc View 2 chunks +16 lines, -25 lines 0 comments Download
M cc/layers/texture_layer_impl.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A cc/layers/texture_layer_impl_unittest.cc View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
M cc/test/layer_test_common.h View 3 chunks +22 lines, -5 lines 0 comments Download
M cc/test/layer_test_common.cc View 1 2 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
danakj
6 years, 9 months ago (2014-03-19 17:57:41 UTC) #1
enne (OOO)
lgtm https://codereview.chromium.org/201153021/diff/20001/cc/layers/io_surface_layer_impl_unittest.cc File cc/layers/io_surface_layer_impl_unittest.cc (right): https://codereview.chromium.org/201153021/diff/20001/cc/layers/io_surface_layer_impl_unittest.cc#newcode50 cc/layers/io_surface_layer_impl_unittest.cc:50: impl.AppendQuadsWithOcclusion(io_surface_layer_impl, occluded); This is a nice cleanup. :)
6 years, 9 months ago (2014-03-19 18:01:19 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-19 18:33:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/201153021/20001
6 years, 9 months ago (2014-03-19 18:33:50 UTC) #4
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 9 months ago (2014-03-19 18:34:37 UTC) #5
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-19 18:35:17 UTC) #6
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
6 years, 9 months ago (2014-03-19 18:46:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/201153021/40001
6 years, 9 months ago (2014-03-19 18:46:59 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 23:25:41 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, browser_tests_swarm http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=284663
6 years, 9 months ago (2014-03-19 23:25:41 UTC) #10
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-19 23:27:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/201153021/40001
6 years, 9 months ago (2014-03-19 23:28:32 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 23:28:54 UTC) #13
commit-bot: I haz the power
Failed to apply patch for cc/cc_tests.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-19 23:28:54 UTC) #14
danakj
6 years, 9 months ago (2014-03-19 23:29:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 manually as r258146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698