Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201153003: Revert 252883 "Remove tests and code for showModalDialog" (Closed)

Created:
6 years, 9 months ago by jamesr
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Revert 252883 "Remove tests and code for showModalDialog" We're leaving this in for M35. > Remove tests and code for showModalDialog > > This deletes the chromium-side implementation logic and a few tests for > showModalDialog. I believe more simplification is possible to do without the > design constraints imposed by showModalDialog but we should probably start > small in case we run into unexpected compat issues. > > R=darin > BUG=345831 > > Review URL: https://codereview.chromium.org/165793003 TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -3 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/test/data/showmodaldialog.html View 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 4 chunks +42 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webkit_browsertest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +22 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/error-body-no-crash.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/webdriver/test_data/alerts.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 9 months ago (2014-03-15 22:43:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/201153003/1
6 years, 9 months ago (2014-03-15 22:43:49 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-15 22:44:48 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-15 22:44:48 UTC) #4
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 9 months ago (2014-03-15 22:52:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/201153003/1
6 years, 9 months ago (2014-03-15 22:53:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/201153003/1
6 years, 9 months ago (2014-03-16 04:42:09 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-16 05:04:42 UTC) #8
Message was sent while issue was closed. 
Change committed as 257356

Powered by Google App Engine
This is Rietveld 408576698