[gn] Configure trace_events for v8 stand-alone

[gn] Configure trace_events for v8 stand-alone

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/15fda5ddcd00b5242577c508404ffa0d36b8045a
Cr-Commit-Position: refs/heads/master@{#36475}

[Michael Achenbach, 2016-05-24 12:14:41]

Description was changed from

==========
[gn] Configure trace_events for v8 stand-alone

BUG=
==========

to

==========
[gn] Configure trace_events for v8 stand-alone

BUG=chromium:474921
NOTRY=true
==========

[Michael Achenbach, 2016-05-24 12:17:53]

machenbach@chromium.org changed reviewers:
+ fmeawad@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-05-24 12:17:54]

PTAL

https://codereview.chromium.org/2011493002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2011493002/diff/1/BUILD.gn#newcode724
BUILD.gn:724: "//base/trace_event/common/trace_event_common.h",
// refers to the project root. Both chromium and v8 stand-alone deps trace_event
into the location: root/base/trace_event/..., where root is either src or v8.

[vogelheim, 2016-05-24 12:26:52]

lgtm

[Michael Achenbach, 2016-05-24 12:44:52]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-05-24 12:45:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011493002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011493002/1

[commit-bot: I haz the power, 2016-05-24 12:47:04]

Description was changed from

==========
[gn] Configure trace_events for v8 stand-alone

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Configure trace_events for v8 stand-alone

BUG=chromium:474921
NOTRY=true
==========

[commit-bot: I haz the power, 2016-05-24 12:47:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-24 12:47:59]

Description was changed from

==========
[gn] Configure trace_events for v8 stand-alone

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Configure trace_events for v8 stand-alone

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/15fda5ddcd00b5242577c508404ffa0d36b8045a
Cr-Commit-Position: refs/heads/master@{#36475}
==========

[commit-bot: I haz the power, 2016-05-24 12:48:00]

Patchset 1 (id:??) landed as
https://crrev.com/15fda5ddcd00b5242577c508404ffa0d36b8045a
Cr-Commit-Position: refs/heads/master@{#36475}

[Nico, 2016-08-03 19:17:31]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-08-03 19:17:32]

https://codereview.chromium.org/2011493002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2011493002/diff/1/BUILD.gn#newcode724
BUILD.gn:724: "//base/trace_event/common/trace_event_common.h",
On 2016/05/24 12:17:53, Michael Achenbach (slow) wrote:
> // refers to the project root. Both chromium and v8 stand-alone deps
trace_event
> into the location: root/base/trace_event/..., where root is either src or v8.

Projects outside of src.git must not depend on base, else it becomes impossible
to change. Say we wanted to rename base/...trace_event_common.h in src. We
currently can't 'cause this file refers to it but it lives in v8.

Please find a way to do what you want to do without having v8 implicitly depend
on base.

[Michael Achenbach, 2016-08-03 19:23:26]

Passing the buck to fmeawad. Could you have a look into this?