Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: BUILD.gn

Issue 2011493002: [gn] Configure trace_events for v8 stand-alone (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 97bb7a3beb47b00863af238527401940e03d7613..6b2408e3f15da55234a5a33608a3b7dde7e9f32e 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -721,8 +721,7 @@ v8_source_set("v8_base") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
- # TODO(fmeawad): This needs to be updated to support standalone V8 builds.
- "../base/trace_event/common/trace_event_common.h",
+ "//base/trace_event/common/trace_event_common.h",
Michael Achenbach 2016/05/24 12:17:53 // refers to the project root. Both chromium and v
Nico 2016/08/03 19:17:31 Projects outside of src.git must not depend on bas
"include/v8-debug.h",
"include/v8-experimental.h",
"include/v8-platform.h",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698