Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 201143002: Update image data upon changing the img.crossorigin attribute. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 9 months ago
Reviewers:
adamk, abarth-chromium
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update image data upon changing the img.crossorigin attribute. The spec tells us that setting the crossorigin attribute on an img element should cause the "update the image data" steps to be invoked, http://www.whatwg.org/specs/web-apps/current-work/#update-the-image-data Do so here, along with updating the underlying test's expectation. R= BUG=341047 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169382

Patch Set 1 #

Patch Set 2 : Fix underlying script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -43 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/images/image-with-origin-header.html View 1 chunk +26 lines, -21 lines 0 comments Download
M LayoutTests/http/tests/images/image-with-origin-header-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/resources/origin.php View 1 1 chunk +3 lines, -15 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
When you have a moment, please take a look.
6 years, 9 months ago (2014-03-16 14:25:12 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-17 18:26:59 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-17 18:57:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/201143002/20001
6 years, 9 months ago (2014-03-17 18:57:23 UTC) #4
commit-bot: I haz the power
Change committed as 169382
6 years, 9 months ago (2014-03-17 19:34:30 UTC) #5
sof
6 years, 9 months ago (2014-03-24 20:48:24 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/210403002/ by sigbjornf@opera.com.

The reason for reverting is: The re-issuing of another image load upon setting
'crossorigin' has been reported to cause a site problem (a Google internal
site/service.)

Until diagnosed and understood fully, let's back this one out..

Powered by Google App Engine
This is Rietveld 408576698