Rename all tbm2 metrics to start with lowercase & add PRESUBMIT

Rename all tbm2 metrics to start with lowercase & add PRESUBMIT

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1254fd14d97fb9ed23c33ba3f2119e6235a59b62

[nednguyen, 2016-05-27 19:51:27]

nednguyen@google.com changed reviewers:
+ eakuefner@chromium.org

[nednguyen, 2016-05-27 19:52:00]

https://codereview.chromium.org/2011403002/diff/1/tracing/bin/validate_all_me...
File tracing/bin/validate_all_metrics (right):

https://codereview.chromium.org/2011403002/diff/1/tracing/bin/validate_all_me...
tracing/bin/validate_all_metrics:41: sys.exit(Main())
Note that this script is run by tracing/PRESUBMIT.py

[nednguyen, 2016-05-27 19:52:12]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 19:52:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011403002/1

[commit-bot: I haz the power, 2016-05-27 20:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 20:09:49]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[eakuefner, 2016-05-27 20:12:07]

lgtm. failures seem unrelated to your patch.

if there are benchmarks using these metrics, i see two ways to resolve it:

1. hard code a hack in timeline_based_measurement.py to change the names to the
right ones before doing the tools/perf patch, or
2. just do the tools/perf patch and let the autoroller sort out the race
condition.

if you choose 2. maybe do it next week so you don't have to watch the roller and
chromium cq tonight.

[nednguyen, 2016-05-27 20:51:07]

On 2016/05/27 20:12:07, eakuefner wrote:
> lgtm. failures seem unrelated to your patch.
> 
> if there are benchmarks using these metrics, i see two ways to resolve it:
> 
> 1. hard code a hack in timeline_based_measurement.py to change the names to
the
> right ones before doing the tools/perf patch, or
> 2. just do the tools/perf patch and let the autoroller sort out the race
> condition.
> 
> if you choose 2. maybe do it next week so you don't have to watch the roller
and
> chromium cq tonight.

I am pretty sure that none of existing benchmarks are using these benchmarks. If
this block the roll, I can also just make a roll + naming update.

[nednguyen, 2016-05-27 20:56:56]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-05-27 20:57:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011403002/1

[commit-bot: I haz the power, 2016-05-27 21:15:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 21:15:54]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[nednguyen, 2016-05-27 22:04:12]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-05-27 22:04:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011403002/1

[commit-bot: I haz the power, 2016-05-27 22:19:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 22:19:52]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[nednguyen, 2016-05-27 22:30:05]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-05-27 22:30:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2011403002/#ps20001
(title: "Update SystemHealthMetric in other files")

[commit-bot: I haz the power, 2016-05-27 22:30:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011403002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011403002/20001

[charliea (OOO until 10-5), 2016-05-27 22:47:07]

THANK YOU! Was just reading through the metric list and the lack of consistency
was killing me. Then I saw that you were landing this CL. Hoorah!

[commit-bot: I haz the power, 2016-05-27 23:33:13]

Description was changed from

==========
Rename all tbm2 metrics to start with lowercase & add PRESUBMIT
==========

to

==========
Rename all tbm2 metrics to start with lowercase & add PRESUBMIT

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-05-27 23:33:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...