tracing/tracing/metrics/system_health/efficiency_metric_test.html - Issue 2011403002: Rename all tbm2 metrics to start with lowercase & add PRESUBMIT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/efficiency_metric_test.html

Issue 2011403002: Rename all tbm2 metrics to start with lowercase & add PRESUBMIT (Closed) Base URL: https://github.com/catapult-project/catapult@master

Patch Set: Update SystemHealthMetric in other files Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/metrics/system_health/efficiency_metric.html ('k') | tracing/tracing/metrics/system_health/power_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/system_health/efficiency_metric_test.html

diff --git a/tracing/tracing/metrics/system_health/efficiency_metric_test.html b/tracing/tracing/metrics/system_health/efficiency_metric_test.html

index af816e2f0a24d16635d7abaa662fdac2e8af7306..5e1f34c39d867b3ddecf3adb0eb99a65fd128c1f 100644

--- a/tracing/tracing/metrics/system_health/efficiency_metric_test.html

+++ b/tracing/tracing/metrics/system_health/efficiency_metric_test.html

@@ -40,7 +40,7 @@ tr.b.unittest.testSuite(function() {

var exp = model.userModel.expectations[0];

tr.b.getOnlyElement(exp.associatedEvents).cpuSelfTime = 10;

var values = new tr.metrics.ValueSet();

- tr.metrics.sh.EfficiencyMetric(values, model);

+ tr.metrics.sh.efficiencyMetric(values, model);

assert.equal(1, values.valueDicts[0].numeric.value);

});

@@ -49,7 +49,7 @@ tr.b.unittest.testSuite(function() {

var exp = model.userModel.expectations[0];

tr.b.getOnlyElement(exp.associatedEvents).cpuSelfTime = 100;

var values = new tr.metrics.ValueSet();

- tr.metrics.sh.EfficiencyMetric(values, model);

+ tr.metrics.sh.efficiencyMetric(values, model);

assert.equal(0, values.valueDicts[0].numeric.value);

});