Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 201133005: Add tests which ensure that the data produced by the preparser is really used. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Add tests which ensure that the data produced by the preparser is really used. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20003

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M test/cctest/test-parsing.cc View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
marja
rossberg, ptal
6 years, 9 months ago (2014-03-17 11:25:31 UTC) #1
rossberg
lgtm https://codereview.chromium.org/201133005/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/201133005/diff/1/test/cctest/test-parsing.cc#newcode315 test/cctest/test-parsing.cc:315: // Note that the ( before function makes ...
6 years, 9 months ago (2014-03-17 12:08:40 UTC) #2
marja
Committed patchset #3 manually as r20003 (presubmit successful).
6 years, 9 months ago (2014-03-17 15:06:39 UTC) #3
rossberg
On 2014/03/17 15:06:39, marja wrote: > Committed patchset #3 manually as r20003 (presubmit successful). Hey ...
6 years, 9 months ago (2014-03-17 15:13:59 UTC) #4
marja
6 years, 9 months ago (2014-03-17 15:15:15 UTC) #5
Message was sent while issue was closed.
Argh, oops, sorry, will make a follow-up CL!

Powered by Google App Engine
This is Rietveld 408576698