Add tests which ensure that the data produced by the preparser is really used.

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 242 matching lines @@
   // Should not crash.
   const char* message = pre_impl->BuildMessage();
   i::Vector<const char*> args = pre_impl->BuildArgs();
   CHECK_GT(strlen(message), 0);
   args.Dispose();
   i::DeleteArray(message);
   delete error_preparse;
 }
 
 
+TEST(PreparseFunctionDataIsUsed) {
+  // This tests that we actually do use the function data generated by the
+  // preparser.
+  v8::Isolate* isolate = CcTest::isolate();
+  v8::HandleScope handles(isolate);
+  v8::Local<v8::Context> context = v8::Context::New(isolate);
+  v8::Context::Scope context_scope(context);
+  int marker;
+  CcTest::i_isolate()->stack_guard()->SetStackLimit(
+      reinterpret_cast<uintptr_t>(&marker) - 128 * 1024);
+
+  const char* good_source =
+      "function this_is_lazy() { var a; } function foo() { return 25; } foo();";
+
+  // Insert a syntax error inside the lazy function.
+  const char* bad_source =
+      "function this_is_lazy() { if (   } function foo() { return 25; } foo();";
+
+  v8::ScriptData* preparse = v8::ScriptData::PreCompile(v8_str(good_source));
+  CHECK(!preparse->HasError());
+
+  // Now compile the erroneous code with the good preparse data. If the preparse
+  // data is used, the lazy function is skipped and it should compile fine.
+  v8::ScriptCompiler::Source source(
+      v8_str(bad_source),
+      v8::ScriptCompiler::CachedData(
+          reinterpret_cast<const uint8_t*>(preparse->Data()),
+          preparse->Length()));
+  v8::Local<v8::Value> result =
+      v8::ScriptCompiler::Compile(CcTest::isolate(), source)->Run();
+  CHECK(result->IsInt32());
+  CHECK_EQ(25, result->Int32Value());
+  delete preparse;
+}
+
+
+TEST(PreparseSymbolDataIsUsed) {
+  // This tests that we actually do use the symbol data generated by the
+  // preparser.
+
+  // Only do one compilation pass in this test (otherwise we will parse the
+  // source code again without preparse data and it will fail).
+  i::FLAG_crankshaft = false;
+
+  v8::Isolate* isolate = CcTest::isolate();
+  v8::HandleScope handles(isolate);
+  v8::Local<v8::Context> context = v8::Context::New(isolate);
+  v8::Context::Scope context_scope(context);
+  int marker;
+  CcTest::i_isolate()->stack_guard()->SetStackLimit(
+      reinterpret_cast<uintptr_t>(&marker) - 128 * 1024);
+
+  // Note that the ( before function makes the

[rossberg, 2014/03/17 12:08:40]

Broken comment?

+  const char* good_source =
+      "(function weird() { var foo = 26; return foo; })()";
+
+  // Insert an undefined identifier. If the preparser data is used, the symbol
+  // stream is used instead, and this identifier resolves correctly to"foo".

[rossberg, 2014/03/17 12:08:40]

Nit: to"foo" -> to "foo"

Also, I personally wouldn't use the word "correctly" here. :)

+  const char* bad_source =
+      "(function weird() { var foo = 26; return wut; })()";
+
+  v8::ScriptData* preparse = v8::ScriptData::PreCompile(v8_str(good_source));
+  CHECK(!preparse->HasError());
+
+  // Now compile the erroneous code with the good preparse data. If the preparse
+  // data is used, we will see a second occurrence of "foo" instead of the
+  // unknown "wut".
+  v8::ScriptCompiler::Source source(
+      v8_str(bad_source),
+      v8::ScriptCompiler::CachedData(
+          reinterpret_cast<const uint8_t*>(preparse->Data()),
+          preparse->Length()));
+  v8::Local<v8::Value> result =
+      v8::ScriptCompiler::Compile(CcTest::isolate(), source)->Run();
+  CHECK(result->IsInt32());
+  CHECK_EQ(26, result->Int32Value());
+  delete preparse;
+}
+
+
 TEST(StandAlonePreParser) {
   v8::V8::Initialize();
 
   int marker;
   CcTest::i_isolate()->stack_guard()->SetStackLimit(
       reinterpret_cast<uintptr_t>(&marker) - 128 * 1024);
 
   const char* programs[] = {
       "{label: 42}",
       "var x = 42;",
@@ skipping 2099 matching lines @@
 
   const char* statement_data[] = {
     statement,
     NULL
   };
 
   // The test is quite slow, so run it with a reduced set of flags.
   static const ParserFlag empty_flags[] = {kAllowLazy};
   RunParserSyncTest(context_data, statement_data, kError, empty_flags, 1);
 }