Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2341)

Unified Diff: build_gyp/standalone.gypi

Issue 2011303003: Match GN and GYP compilation warning flags (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_gyp/standalone.gypi
diff --git a/build_gyp/standalone.gypi b/build_gyp/standalone.gypi
index f191c28e42677cec6e1fad1436443d052750d52f..1fa07dcc0f4d54cfaf6a50a51d03edbd59aee074 100644
--- a/build_gyp/standalone.gypi
+++ b/build_gyp/standalone.gypi
@@ -202,13 +202,6 @@
},
'msvs_disabled_warnings': [
# ####
- # This section is PDFium specific.
Lei Zhang 2016/05/27 23:49:20 Can you leave this section here? We still refer to
Wei Li 2016/05/28 00:11:59 sure.
- # ####
-
- # C4800: forcing value to bool 'true' or 'false' (performance warning)
Lei Zhang 2016/05/27 23:49:20 Just mention this section is currently empty.
Wei Li 2016/05/28 00:11:59 Done.
- 4800,
-
- # ####
# This section should match Chromium's build/common.gypi.
# ####
@@ -479,6 +472,10 @@
'-Wno-unused-variable',
],
},
+ 'msvs_disabled_warnings': [
+ # forcing value to bool 'true' or 'false' (performance warning)
+ 4800,
+ ],
'msvs_settings': {
'VCCLCompilerTool': {
'WarningLevel': '3',
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698