Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2011263002: Implement RenderPassId StructTrait (Closed)

Created:
4 years, 7 months ago by Fady Samuel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement RenderPassId StructTrait BUG=611802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/70eee944ac0e80daf3a0c95b46eb647bf95f6e07 Cr-Commit-Position: refs/heads/master@{#396549}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix deps #

Patch Set 4 : Fix deps for real this time I hope #

Patch Set 5 : Rebased #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -65 lines) Patch
M cc/ipc/BUILD.gn View 3 4 1 chunk +1 line, -0 lines 0 comments Download
A + cc/ipc/render_pass_id.mojom View 1 chunk +4 lines, -3 lines 0 comments Download
A cc/ipc/render_pass_id.typemap View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A cc/ipc/render_pass_id_struct_traits.h View 1 chunk +29 lines, -0 lines 1 comment Download
M cc/ipc/typemaps.gni View 1 chunk +4 lines, -1 line 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.h View 1 chunk +0 lines, -12 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.cc View 6 chunks +6 lines, -30 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_utils.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/mus/public/cpp/surfaces/tests/surface_unittest.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M components/mus/public/interfaces/quads.mojom View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 29 (13 generated)
Fady Samuel
+tsepez@ for ipc +ben@ for mus +danakj@ for cc (I may TBR since you're away)
4 years, 7 months ago (2016-05-27 02:15:23 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011263002/1
4 years, 6 months ago (2016-05-27 12:35:05 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/197465)
4 years, 6 months ago (2016-05-27 13:59:08 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011263002/20001
4 years, 6 months ago (2016-05-27 15:30:09 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011263002/40001
4 years, 6 months ago (2016-05-27 16:42:31 UTC) #11
Tom Sepez
lgtm
4 years, 6 months ago (2016-05-27 16:44:43 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/86505) android_arm64_dbg_recipe on ...
4 years, 6 months ago (2016-05-27 16:46:24 UTC) #14
Ben Goodger (Google)
mus lgtm
4 years, 6 months ago (2016-05-27 16:47:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011263002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011263002/60001
4 years, 6 months ago (2016-05-27 17:14:12 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/86507) android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, ...
4 years, 6 months ago (2016-05-27 17:18:11 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011263002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011263002/80001
4 years, 6 months ago (2016-05-27 19:07:57 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-05-27 20:13:56 UTC) #24
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/70eee944ac0e80daf3a0c95b46eb647bf95f6e07 Cr-Commit-Position: refs/heads/master@{#396549}
4 years, 6 months ago (2016-05-27 20:16:42 UTC) #26
danakj
https://codereview.chromium.org/2011263002/diff/80001/cc/ipc/render_pass_id_struct_traits.h File cc/ipc/render_pass_id_struct_traits.h (right): https://codereview.chromium.org/2011263002/diff/80001/cc/ipc/render_pass_id_struct_traits.h#newcode1 cc/ipc/render_pass_id_struct_traits.h:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
4 years, 6 months ago (2016-05-31 21:34:24 UTC) #27
Fady Samuel
On 2016/05/31 21:34:24, danakj wrote: > https://codereview.chromium.org/2011263002/diff/80001/cc/ipc/render_pass_id_struct_traits.h > File cc/ipc/render_pass_id_struct_traits.h (right): > > https://codereview.chromium.org/2011263002/diff/80001/cc/ipc/render_pass_id_struct_traits.h#newcode1 > ...
4 years, 6 months ago (2016-05-31 21:37:24 UTC) #28
danakj
4 years, 6 months ago (2016-05-31 21:39:50 UTC) #29
Message was sent while issue was closed. 
Ah ok thanks LGTM

Powered by Google App Engine
This is Rietveld 408576698