Record start up latency of DOM distiller viewer

Record start up latency of DOM distiller viewer

BUG=617701
Committed: https://crrev.com/b744ad3dc31c3d441687e9b99fac3eee22e90e32
Cr-Commit-Position: refs/heads/master@{#398115}

[wychen, 2016-05-26 23:01:39]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2016-05-26 23:01:40]

PTAL

[mdjones, 2016-05-31 17:26:25]

https://codereview.chromium.org/2011213002/diff/1/chrome/browser/dom_distille...
File chrome/browser/dom_distiller/tab_utils.cc (right):

https://codereview.chromium.org/2011213002/diff/1/chrome/browser/dom_distille...
chrome/browser/dom_distiller/tab_utils.cc:110: (base::TimeTicks::Now() -
base::TimeTicks()).InMilliseconds());
I'm not sure I understand why the subtraction is needed.

[wychen, 2016-05-31 17:59:26]

https://codereview.chromium.org/2011213002/diff/1/chrome/browser/dom_distille...
File chrome/browser/dom_distiller/tab_utils.cc (right):

https://codereview.chromium.org/2011213002/diff/1/chrome/browser/dom_distille...
chrome/browser/dom_distiller/tab_utils.cc:110: (base::TimeTicks::Now() -
base::TimeTicks()).InMilliseconds());
On 2016/05/31 17:26:25, mdjones wrote:
> I'm not sure I understand why the subtraction is needed.

TimeTicks cannot be directly converted to int. TimeDelta can.

[mdjones, 2016-06-03 23:31:56]

lgtm

[wychen, 2016-06-03 23:36:30]

wychen@chromium.org changed reviewers:
+ jwd@chromium.org, rkaplow@chromium.org

[wychen, 2016-06-03 23:36:31]

+rkaplow@, PTAL at histogram. Thanks!

[rkaplow, 2016-06-06 14:56:35]

lgtm

[wychen, 2016-06-06 18:12:36]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 18:13:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011213002/1

[wychen, 2016-06-06 18:16:37]

Description was changed from

==========
Record start up latency of DOM distiller viewer

BUG=
==========

to

==========
Record start up latency of DOM distiller viewer

BUG=617701
==========

[commit-bot: I haz the power, 2016-06-06 20:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 20:20:27]

Dry run: This issue passed the CQ dry run.

[wychen, 2016-06-06 20:27:09]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2016-06-06 20:28:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011213002/1

[commit-bot: I haz the power, 2016-06-06 20:38:24]

Description was changed from

==========
Record start up latency of DOM distiller viewer

BUG=617701
==========

to

==========
Record start up latency of DOM distiller viewer

BUG=617701
==========

[commit-bot: I haz the power, 2016-06-06 20:38:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-06 20:40:26]

Description was changed from

==========
Record start up latency of DOM distiller viewer

BUG=617701
==========

to

==========
Record start up latency of DOM distiller viewer

BUG=617701

Committed: https://crrev.com/b744ad3dc31c3d441687e9b99fac3eee22e90e32
Cr-Commit-Position: refs/heads/master@{#398115}
==========

[commit-bot: I haz the power, 2016-06-06 20:40:28]

Patchset 1 (id:??) landed as
https://crrev.com/b744ad3dc31c3d441687e9b99fac3eee22e90e32
Cr-Commit-Position: refs/heads/master@{#398115}