Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: components/dom_distiller/core/url_utils.cc

Issue 2011213002: Record start up latency of DOM distiller viewer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/url_utils.cc
diff --git a/components/dom_distiller/core/url_utils.cc b/components/dom_distiller/core/url_utils.cc
index cfe4fcb9a21398cec21c8f68c5cf8d9b13147cb7..c1bb35fcaf41f0560a0da64d483698bfa998092c 100644
--- a/components/dom_distiller/core/url_utils.cc
+++ b/components/dom_distiller/core/url_utils.cc
@@ -7,6 +7,7 @@
#include <string>
#include "base/guid.h"
+#include "base/strings/string_number_conversions.h"
#include "components/dom_distiller/core/url_constants.h"
#include "grit/components_resources.h"
#include "net/base/url_util.h"
@@ -30,8 +31,13 @@ const GURL GetDistillerViewUrlFromEntryId(const std::string& scheme,
}
const GURL GetDistillerViewUrlFromUrl(const std::string& scheme,
- const GURL& view_url) {
+ const GURL& view_url,
+ int64_t start_time_ms) {
GURL url(scheme + "://" + base::GenerateGUID());
+ if (start_time_ms > 0) {
+ url = net::AppendOrReplaceQueryParameter(url, kTimeKey,
+ base::IntToString(start_time_ms));
+ }
return net::AppendOrReplaceQueryParameter(url, kUrlKey, view_url.spec());
}
@@ -45,6 +51,21 @@ const GURL GetOriginalUrlFromDistillerUrl(const GURL& url) {
return GURL(original_url_str);
}
+int64_t GetTimeFromDistillerUrl(const GURL& url) {
+ if (!dom_distiller::url_utils::IsDistilledPage(url))
+ return 0;
+
+ std::string time_str;
+ if (!net::GetValueForKeyInQuery(url, kTimeKey, &time_str))
+ return 0;
+
+ int64_t time_int = 0;
+ if (!base::StringToInt64(time_str, &time_int))
+ return 0;
+
+ return time_int;
+}
+
std::string GetValueForKeyInUrl(const GURL& url, const std::string& key) {
if (!url.is_valid())
return "";

Powered by Google App Engine
This is Rietveld 408576698