Simplify _builder_options in webkitpy.layout_tests.port.factory.

Simplify _builder_options in webkitpy.layout_tests.port.factory.

Minor clean-up change, not urgent.

Committed: https://crrev.com/a7740de0cd9d7bd1d764399469a38576f53a58f2
Cr-Commit-Position: refs/heads/master@{#397055}

[qyearsley, 2016-05-26 16:58:01]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, ojan@chromium.org

[qyearsley, 2016-05-26 16:58:02]

https://codereview.chromium.org/2011053002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py
(left):

https://codereview.chromium.org/2011053002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py:65:
configuration = "Debug" if re.search(r"[d|D](ebu|b)g", builder_name) else
"Release"
There are no builder names with Debug, Dbg or debug in the names now -- only
dbg.
Note that in webkitpy.layout_tests.builder_list there's another little bit of
logic is used to decide whether a builder name is debug or not (and it checks
whether the name contains "dbg". This could be merged later.

https://codereview.chromium.org/2011053002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py:66:
is_webkit2 = "WK2" in builder_name
There are no builder names with WK2 now.

[qyearsley, 2016-05-28 16:26:31]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-28 16:26:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011053002/1

[commit-bot: I haz the power, 2016-05-28 17:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-28 17:41:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qyearsley, 2016-05-28 19:45:45]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-28 19:45:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011053002/20001

[commit-bot: I haz the power, 2016-05-28 20:50:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-28 20:50:51]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-06-01 00:22:54]

lgtm

[qyearsley, 2016-06-01 03:12:16]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-06-01 03:12:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011053002/20001

[commit-bot: I haz the power, 2016-06-01 04:21:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 04:22:42]

Description was changed from

==========
Simplify _builder_options in webkitpy.layout_tests.port.factory.

Minor clean-up change, not urgent.
==========

to

==========
Simplify _builder_options in webkitpy.layout_tests.port.factory.

Minor clean-up change, not urgent.

Committed: https://crrev.com/a7740de0cd9d7bd1d764399469a38576f53a58f2
Cr-Commit-Position: refs/heads/master@{#397055}
==========

[commit-bot: I haz the power, 2016-06-01 04:22:43]

Patchset 2 (id:??) landed as
https://crrev.com/a7740de0cd9d7bd1d764399469a38576f53a58f2
Cr-Commit-Position: refs/heads/master@{#397055}