third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py - Issue 2011053002: Simplify _builder_options in webkitpy.layout_tests.port.factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

Issue 2011053002: Simplify _builder_options in webkitpy.layout_tests.port.factory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't change "configuration" part in this CL Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

index 3617dc74a87e00b7d0a8dc48e36ca4147115d794..a27f8b245f0b47446b8ae40ab3eac0b36e5288f2 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

@@ -62,10 +62,11 @@ def configuration_options():

def _builder_options(builder_name):

- configuration = "Debug" if re.search(r"[d|D](ebu|b)g", builder_name) else "Release"

- is_webkit2 = "WK2" in builder_name

- builder_name = builder_name

- return optparse.Values({'builder_name': builder_name, 'configuration': configuration, 'target': None})

+ return optparse.Values({

+ 'builder_name': builder_name,

+ 'configuration': "Debug" if re.search(r"[d|D](ebu|b)g", builder_name) else "Release",

+ 'target': None,

+ })

def _check_configuration_and_target(host, options):

« no previous file with comments | « no previous file | no next file » | no next file with comments »