tools/clang/scripts/update.py - Issue 2011023002: 💈 Remove most GYP_DEFINES logic from tools/clang/scripts/update.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/scripts/update.py

Issue 2011023002: 💈 Remove most GYP_DEFINES logic from tools/clang/scripts/update.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert use_head_revision part Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/scripts/update.py

diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py

index baac014965af7e69c9699540269c52e6d0fa3f29..36b106d8c8e56858605eb75ee4ad324fcc4be95b 100755

--- a/tools/clang/scripts/update.py

+++ b/tools/clang/scripts/update.py

@@ -377,9 +377,7 @@ def UpdateClang(args):

print 'Updating Clang to %s...' % PACKAGE_VERSION

need_gold_plugin = 'LLVM_DOWNLOAD_GOLD_PLUGIN' in os.environ or (

- sys.platform.startswith('linux') and

- 'buildtype=Official' in os.environ.get('GYP_DEFINES', '') and

- 'branding=Chrome' in os.environ.get('GYP_DEFINES', ''))

+ sys.platform.startswith('linux'))

if ReadStampFile() == PACKAGE_VERSION and not args.force_local_build:

print 'Clang is already up to date.'

« no previous file with comments | « no previous file | no next file » | no next file with comments »