Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: tools/clang/scripts/update.py

Issue 2011023002: 💈 Remove most GYP_DEFINES logic from tools/clang/scripts/update.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert use_head_revision part Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """This script is used to download prebuilt clang binaries. 6 """This script is used to download prebuilt clang binaries.
7 7
8 It is also used by package.py to build the prebuilt clang binaries.""" 8 It is also used by package.py to build the prebuilt clang binaries."""
9 9
10 import argparse 10 import argparse
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 # This script always wants to use the 64-bit msdia*.dll. 370 # This script always wants to use the 64-bit msdia*.dll.
371 dia_path = os.path.join(GetVSVersion().Path(), 'DIA SDK', 'bin', 'amd64') 371 dia_path = os.path.join(GetVSVersion().Path(), 'DIA SDK', 'bin', 'amd64')
372 dia_dll = os.path.join(dia_path, DIA_DLL[GetVSVersion().ShortName()]) 372 dia_dll = os.path.join(dia_path, DIA_DLL[GetVSVersion().ShortName()])
373 CopyFile(dia_dll, target_dir) 373 CopyFile(dia_dll, target_dir)
374 374
375 375
376 def UpdateClang(args): 376 def UpdateClang(args):
377 print 'Updating Clang to %s...' % PACKAGE_VERSION 377 print 'Updating Clang to %s...' % PACKAGE_VERSION
378 378
379 need_gold_plugin = 'LLVM_DOWNLOAD_GOLD_PLUGIN' in os.environ or ( 379 need_gold_plugin = 'LLVM_DOWNLOAD_GOLD_PLUGIN' in os.environ or (
380 sys.platform.startswith('linux') and 380 sys.platform.startswith('linux'))
381 'buildtype=Official' in os.environ.get('GYP_DEFINES', '') and
382 'branding=Chrome' in os.environ.get('GYP_DEFINES', ''))
383 381
384 if ReadStampFile() == PACKAGE_VERSION and not args.force_local_build: 382 if ReadStampFile() == PACKAGE_VERSION and not args.force_local_build:
385 print 'Clang is already up to date.' 383 print 'Clang is already up to date.'
386 if not need_gold_plugin or os.path.exists( 384 if not need_gold_plugin or os.path.exists(
387 os.path.join(LLVM_BUILD_DIR, "lib/LLVMgold.so")): 385 os.path.join(LLVM_BUILD_DIR, "lib/LLVMgold.so")):
388 return 0 386 return 0
389 387
390 # Reset the stamp file in case the build is unsuccessful. 388 # Reset the stamp file in case the build is unsuccessful.
391 WriteStampFile('') 389 WriteStampFile('')
392 390
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
877 args.force_local_build = True 875 args.force_local_build = True
878 if 'OS=android' not in os.environ.get('GYP_DEFINES', ''): 876 if 'OS=android' not in os.environ.get('GYP_DEFINES', ''):
879 # Only build the Android ASan rt on ToT bots when targetting Android. 877 # Only build the Android ASan rt on ToT bots when targetting Android.
880 args.with_android = False 878 args.with_android = False
881 879
882 return UpdateClang(args) 880 return UpdateClang(args)
883 881
884 882
885 if __name__ == '__main__': 883 if __name__ == '__main__':
886 sys.exit(main()) 884 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698