Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2010993002: Migrate UnlinkedParam.defaultValue to UnlinkedExecutable.bodyExpr. (Closed)

Created:
4 years, 6 months ago by Paul Berry
Modified:
4 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate UnlinkedParam.defaultValue to UnlinkedExecutable.bodyExpr. To do AST-based type inference involving function closures, we have added a `bodyExpr` field to UnlinkedExecutable. Since every UnlinkedParam with a default value has a corresponding UnlinkedExecutable representing its initializer, it makes sense to store the constant expression there for uniformity. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8d43e021744dc880ed3f9dc04145d87765b9a9ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -77 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 11 chunks +3 lines, -35 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 1 chunk +1 line, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +1 line, -9 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 12 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 6 months ago (2016-05-26 11:33:22 UTC) #2
scheglov
LGTM
4 years, 6 months ago (2016-05-26 13:50:20 UTC) #3
Paul Berry
4 years, 6 months ago (2016-05-26 15:12:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d43e021744dc880ed3f9dc04145d87765b9a9ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698