Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: pkg/analyzer/test/src/summary/summary_common.dart

Issue 2010993002: Migrate UnlinkedParam.defaultValue to UnlinkedExecutable.bodyExpr. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/summary_common.dart
diff --git a/pkg/analyzer/test/src/summary/summary_common.dart b/pkg/analyzer/test/src/summary/summary_common.dart
index 27bebab4deb5485631c1e04c2156fbc1ec8f3a0a..639b2a15795a86654fe3b092b654b73d22ca8929 100644
--- a/pkg/analyzer/test/src/summary/summary_common.dart
+++ b/pkg/analyzer/test/src/summary/summary_common.dart
@@ -3702,7 +3702,7 @@ int foo() => 0;
expect(param.isFunctionTyped, isTrue);
expect(param.kind, UnlinkedParamKind.positional);
expect(param.defaultValueCode, 'foo');
- _assertUnlinkedConst(param.defaultValue, operators: [
+ _assertUnlinkedConst(param.initializer.bodyExpr, operators: [
UnlinkedConstOperation.pushReference
], referenceValidators: [
(EntityRef r) => checkTypeRef(r, null, null, 'foo',
@@ -3734,7 +3734,7 @@ int foo() => 0;
.executables);
UnlinkedParam parameter = executable.parameters[0];
expect(parameter.kind, UnlinkedParamKind.named);
- expect(parameter.defaultValue, isNull);
+ expect(parameter.initializer, isNull);
expect(parameter.defaultValueCode, isEmpty);
}
@@ -3747,7 +3747,7 @@ int foo() => 0;
expect(parameter.initializer, isNotNull);
expect(parameter.defaultValueCode, '42');
_assertCodeRange(parameter.codeRange, 13, 10);
- _assertUnlinkedConst(parameter.defaultValue,
+ _assertUnlinkedConst(parameter.initializer.bodyExpr,
operators: [UnlinkedConstOperation.pushInt], ints: [42]);
}
@@ -3765,7 +3765,7 @@ int foo() => 0;
.executables);
UnlinkedParam parameter = executable.parameters[0];
expect(parameter.kind, UnlinkedParamKind.positional);
- expect(parameter.defaultValue, isNull);
+ expect(parameter.initializer, isNull);
expect(parameter.defaultValueCode, isEmpty);
}
@@ -3779,7 +3779,7 @@ int foo() => 0;
expect(parameter.initializer, isNotNull);
expect(parameter.defaultValueCode, '42');
_assertCodeRange(parameter.codeRange, 13, 11);
- _assertUnlinkedConst(parameter.defaultValue,
+ _assertUnlinkedConst(parameter.initializer.bodyExpr,
operators: [UnlinkedConstOperation.pushInt], ints: [42]);
}
@@ -3811,7 +3811,7 @@ class C {
UnlinkedParam param = executable.parameters[0];
expect(param.kind, UnlinkedParamKind.positional);
expect(param.defaultValueCode, '42');
- _assertUnlinkedConst(param.defaultValue,
+ _assertUnlinkedConst(param.initializer.bodyExpr,
operators: [UnlinkedConstOperation.pushInt], ints: [42]);
}
@@ -5806,7 +5806,7 @@ int foo(int a, String b) => 0;
expect(param.kind, UnlinkedParamKind.positional);
expect(param.initializer, isNotNull);
expect(param.defaultValueCode, 'foo');
- _assertUnlinkedConst(param.defaultValue, operators: [
+ _assertUnlinkedConst(param.initializer.bodyExpr, operators: [
UnlinkedConstOperation.pushReference
], referenceValidators: [
(EntityRef r) => checkTypeRef(r, null, null, 'foo',
@@ -5819,7 +5819,6 @@ int foo(int a, String b) => 0;
UnlinkedParam param = executable.parameters[0];
expect(param.kind, UnlinkedParamKind.named);
expect(param.initializer, isNull);
- expect(param.defaultValue, isNull);
expect(param.defaultValueCode, isEmpty);
}
@@ -5830,7 +5829,7 @@ int foo(int a, String b) => 0;
expect(param.initializer, isNotNull);
expect(param.defaultValueCode, '42');
_assertCodeRange(param.codeRange, 3, 5);
- _assertUnlinkedConst(param.defaultValue,
+ _assertUnlinkedConst(param.initializer.bodyExpr,
operators: [UnlinkedConstOperation.pushInt], ints: [42]);
}
@@ -5839,7 +5838,6 @@ int foo(int a, String b) => 0;
UnlinkedParam param = executable.parameters[0];
expect(param.kind, UnlinkedParamKind.positional);
expect(param.initializer, isNull);
- expect(param.defaultValue, isNull);
expect(param.defaultValueCode, isEmpty);
}
@@ -5850,7 +5848,7 @@ int foo(int a, String b) => 0;
expect(param.initializer, isNotNull);
expect(param.defaultValueCode, '42');
_assertCodeRange(param.codeRange, 3, 6);
- _assertUnlinkedConst(param.defaultValue,
+ _assertUnlinkedConst(param.initializer.bodyExpr,
operators: [UnlinkedConstOperation.pushInt], ints: [42]);
}
@@ -5859,7 +5857,6 @@ int foo(int a, String b) => 0;
UnlinkedParam param = executable.parameters[0];
expect(param.kind, UnlinkedParamKind.required);
expect(param.initializer, isNull);
- expect(param.defaultValue, isNull);
expect(param.defaultValueCode, isEmpty);
}
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698