Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201083004: Oilpan: move History to the oilpan heap. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 9 months ago
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Drop redundant 'explicit' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M Source/core/events/PopStateEvent.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/events/PopStateEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/History.h View 3 chunks +8 lines, -2 lines 0 comments Download
M Source/core/frame/History.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
sof
Please take a look.
6 years, 9 months ago (2014-03-19 09:45:44 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 9 months ago (2014-03-19 09:48:47 UTC) #2
haraken
LGTM https://codereview.chromium.org/201083004/diff/1/Source/core/events/PopStateEvent.h File Source/core/events/PopStateEvent.h (right): https://codereview.chromium.org/201083004/diff/1/Source/core/events/PopStateEvent.h#newcode62 Source/core/events/PopStateEvent.h:62: explicit PopStateEvent(PassRefPtr<SerializedScriptValue>, PassRefPtrWillBeRawPtr<History>); Drop explicit.
6 years, 9 months ago (2014-03-19 09:58:48 UTC) #3
sof
https://codereview.chromium.org/201083004/diff/1/Source/core/events/PopStateEvent.h File Source/core/events/PopStateEvent.h (right): https://codereview.chromium.org/201083004/diff/1/Source/core/events/PopStateEvent.h#newcode62 Source/core/events/PopStateEvent.h:62: explicit PopStateEvent(PassRefPtr<SerializedScriptValue>, PassRefPtrWillBeRawPtr<History>); On 2014/03/19 09:58:48, haraken wrote: > ...
6 years, 9 months ago (2014-03-19 10:05:39 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-19 10:05:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/201083004/20001
6 years, 9 months ago (2014-03-19 10:05:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 10:06:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-19 10:06:59 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-19 10:08:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/201083004/20001
6 years, 9 months ago (2014-03-19 10:08:40 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 11:04:40 UTC) #11
Message was sent while issue was closed. 
Change committed as 169540

Powered by Google App Engine
This is Rietveld 408576698