Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: Source/core/frame/History.h

Issue 201083004: Oilpan: move History to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Drop redundant 'explicit' Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | Source/core/frame/History.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/History.h
diff --git a/Source/core/frame/History.h b/Source/core/frame/History.h
index e33005222a7fb2faddd9e956f66856bc14194c8e..30a1c34abbbb0115d24e72450e90443c381c7679 100644
--- a/Source/core/frame/History.h
+++ b/Source/core/frame/History.h
@@ -30,6 +30,7 @@
#include "bindings/v8/SerializedScriptValue.h"
#include "core/loader/FrameLoaderTypes.h"
#include "core/frame/DOMWindowProperty.h"
+#include "heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
@@ -41,9 +42,12 @@ class KURL;
class ExecutionContext;
class ExceptionState;
-class History FINAL : public ScriptWrappable, public RefCounted<History>, public DOMWindowProperty {
+class History FINAL : public RefCountedWillBeGarbageCollectedFinalized<History>, public ScriptWrappable, public DOMWindowProperty {
public:
- static PassRefPtr<History> create(LocalFrame* frame) { return adoptRef(new History(frame)); }
+ static PassRefPtrWillBeRawPtr<History> create(LocalFrame* frame)
+ {
+ return adoptRefWillBeNoop(new History(frame));
+ }
unsigned length() const;
SerializedScriptValue* state();
@@ -57,6 +61,8 @@ public:
void stateObjectAdded(PassRefPtr<SerializedScriptValue>, const String& title, const String& url, UpdateBackForwardListPolicy, ExceptionState&);
+ void trace(Visitor*) { }
+
private:
explicit History(LocalFrame*);
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | Source/core/frame/History.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698