Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: core/fxge/skia/fx_skia_device.h

Issue 2010813003: Remove default arguments from CFX_FxgeDevice. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@fxgeclean2_textrenderer
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fxge/include/fx_ge.h ('k') | core/fxge/skia/fx_skia_device.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CORE_FXGE_SKIA_FX_SKIA_DEVICE_H_ 5 #ifndef CORE_FXGE_SKIA_FX_SKIA_DEVICE_H_
6 #define CORE_FXGE_SKIA_FX_SKIA_DEVICE_H_ 6 #define CORE_FXGE_SKIA_FX_SKIA_DEVICE_H_
7 7
8 #if defined(_SKIA_SUPPORT_) 8 #if defined(_SKIA_SUPPORT_)
9 9
10 class SkCanvas; 10 class SkCanvas;
11 class SkMatrix; 11 class SkMatrix;
12 class SkPaint; 12 class SkPaint;
13 class SkPath; 13 class SkPath;
14 class SkPictureRecorder; 14 class SkPictureRecorder;
15 struct SkIRect; 15 struct SkIRect;
16 16
17 class CFX_SkiaDeviceDriver : public IFX_RenderDeviceDriver { 17 class CFX_SkiaDeviceDriver : public IFX_RenderDeviceDriver {
18 public: 18 public:
19 CFX_SkiaDeviceDriver(CFX_DIBitmap* pBitmap, 19 CFX_SkiaDeviceDriver(CFX_DIBitmap* pBitmap,
20 int dither_bits,
21 FX_BOOL bRgbByteOrder, 20 FX_BOOL bRgbByteOrder,
22 CFX_DIBitmap* pOriDevice, 21 CFX_DIBitmap* pOriDevice,
23 FX_BOOL bGroupKnockout); 22 FX_BOOL bGroupKnockout);
24 CFX_SkiaDeviceDriver(SkPictureRecorder* recorder); 23 explicit CFX_SkiaDeviceDriver(SkPictureRecorder* recorder);
25 CFX_SkiaDeviceDriver(int size_x, int size_y); 24 CFX_SkiaDeviceDriver(int size_x, int size_y);
26 ~CFX_SkiaDeviceDriver() override; 25 ~CFX_SkiaDeviceDriver() override;
27 26
28 /** Options */ 27 /** Options */
29 int GetDeviceCaps(int caps_id) override; 28 int GetDeviceCaps(int caps_id) override;
30 29
31 /** Save and restore all graphic states */ 30 /** Save and restore all graphic states */
32 void SaveState() override; 31 void SaveState() override;
33 void RestoreState(bool bKeepSaved) override; 32 void RestoreState(bool bKeepSaved) override;
34 33
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 void PaintStroke(SkPaint* spaint, 137 void PaintStroke(SkPaint* spaint,
139 const CFX_GraphStateData* pGraphState, 138 const CFX_GraphStateData* pGraphState,
140 const SkMatrix& matrix); 139 const SkMatrix& matrix);
141 SkPictureRecorder* GetRecorder() const { return m_pRecorder; } 140 SkPictureRecorder* GetRecorder() const { return m_pRecorder; }
142 141
143 private: 142 private:
144 CFX_DIBitmap* m_pBitmap; 143 CFX_DIBitmap* m_pBitmap;
145 CFX_DIBitmap* m_pOriDevice; 144 CFX_DIBitmap* m_pOriDevice;
146 SkCanvas* m_pCanvas; 145 SkCanvas* m_pCanvas;
147 SkPictureRecorder* const m_pRecorder; 146 SkPictureRecorder* const m_pRecorder;
148 int m_ditherBits;
149 FX_BOOL m_bRgbByteOrder; 147 FX_BOOL m_bRgbByteOrder;
150 FX_BOOL m_bGroupKnockout; 148 FX_BOOL m_bGroupKnockout;
151 }; 149 };
152 #endif // defined(_SKIA_SUPPORT_) 150 #endif // defined(_SKIA_SUPPORT_)
153 151
154 #endif // CORE_FXGE_SKIA_FX_SKIA_DEVICE_H_ 152 #endif // CORE_FXGE_SKIA_FX_SKIA_DEVICE_H_
OLDNEW
« no previous file with comments | « core/fxge/include/fx_ge.h ('k') | core/fxge/skia/fx_skia_device.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698