Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010613003: Move BorderEdgeFlags out of LayoutBoxModelObject.h, so that BoxBorderPainter.h doesn't have to incl… (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move BorderEdgeFlags out of LayoutBoxModelObject.h, so that BoxBorderPainter.h doesn't have to include it. BUG=614015 TBR=chrishtr@chromium.org,eae@chromium.org Committed: https://crrev.com/292f29f4145ab3d099128dfdd9b4e465dc62f76a Cr-Commit-Position: refs/heads/master@{#395875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxBorderPainter.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-25 09:56:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010613003/1
4 years, 7 months ago (2016-05-25 09:56:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 13:11:01 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/292f29f4145ab3d099128dfdd9b4e465dc62f76a Cr-Commit-Position: refs/heads/master@{#395875}
4 years, 7 months ago (2016-05-25 13:12:29 UTC) #9
chrishtr
lgtm
4 years, 7 months ago (2016-05-25 15:03:40 UTC) #10
eae
4 years, 7 months ago (2016-05-25 15:23:37 UTC) #11
Message was sent while issue was closed. 
LGTM post-facto

Powered by Google App Engine
This is Rietveld 408576698