third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp - Issue 2010603002: Use SourceLocation when reporting runtime exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

Issue 2010603002: Use SourceLocation when reporting runtime exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2004243002

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

index c9bc6ce693965f95f10bdf9922540a3e1ecd8b79..91cf060dccd5746178f77f1b57ac2fb9aee6e5b0 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

@@ -72,7 +72,7 @@ V8StackTraceImpl::Frame::~Frame()

{

}

-// buildInspectorObject() and ScriptCallStack's toTracedValue() should set the same fields.

+// buildInspectorObject() and SourceLocation's toTracedValue() should set the same fields.

// If either of them is modified, the other should be also modified.

PassOwnPtr<protocol::Runtime::CallFrame> V8StackTraceImpl::Frame::buildInspectorObject() const

{