Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

Issue 2010603002: Use SourceLocation when reporting runtime exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2004243002
Patch Set: test fixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SourceLocation_h 5 #ifndef SourceLocation_h
6 #define SourceLocation_h 6 #define SourceLocation_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "platform/v8_inspector/public/V8StackTrace.h" 9 #include "platform/v8_inspector/public/V8StackTrace.h"
10 #include "wtf/Forward.h" 10 #include "wtf/Forward.h"
11 #include "wtf/PassOwnPtr.h" 11 #include "wtf/PassOwnPtr.h"
12 #include "wtf/text/WTFString.h" 12 #include "wtf/text/WTFString.h"
13 13
14 namespace blink { 14 namespace blink {
15 15
16 class ExecutionContext; 16 class ExecutionContext;
17 class TracedValue; 17 class TracedValue;
18 class V8StackTrace; 18 class V8StackTrace;
19 19
20 class CORE_EXPORT SourceLocation { 20 class CORE_EXPORT SourceLocation {
21 public: 21 public:
22 // Zero lineNumber and columnNumber mean unknown. Captures current stack tra ce. 22 // Zero lineNumber and columnNumber mean unknown. Captures current stack tra ce.
23 static PassOwnPtr<SourceLocation> capture(const String& url, unsigned lineNu mber, unsigned columnNumber); 23 static PassOwnPtr<SourceLocation> capture(const String& url, unsigned lineNu mber, unsigned columnNumber);
24 24
25 // Shortcut when location is unknown. Tries to capture call stack or parsing location if available. 25 // Shortcut when location is unknown. Tries to capture call stack or parsing location if available.
26 static PassOwnPtr<SourceLocation> capture(ExecutionContext* = nullptr); 26 static PassOwnPtr<SourceLocation> capture(ExecutionContext* = nullptr);
27 27
28 static PassOwnPtr<SourceLocation> fromMessage(v8::Isolate*, v8::Local<v8::Me ssage>, ExecutionContext*);
29
28 static PassOwnPtr<SourceLocation> create(const String& url, unsigned lineNum ber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId = 0); 30 static PassOwnPtr<SourceLocation> create(const String& url, unsigned lineNum ber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId = 0);
29 ~SourceLocation(); 31 ~SourceLocation();
30 32
31 bool isEmpty() const { return m_url.isNull(); } 33 bool isEmpty() const { return m_url.isNull(); }
32 String url() const { return m_url; } 34 String url() const { return m_url; }
33 unsigned lineNumber() const { return m_lineNumber; } 35 unsigned lineNumber() const { return m_lineNumber; }
34 unsigned columnNumber() const { return m_columnNumber; } 36 unsigned columnNumber() const { return m_columnNumber; }
35 std::unique_ptr<V8StackTrace> takeStackTrace() { return std::move(m_stackTra ce); } 37 std::unique_ptr<V8StackTrace> takeStackTrace() { return std::move(m_stackTra ce); }
36 int scriptId() const { return m_scriptId; } 38 int scriptId() const { return m_scriptId; }
37 void toTracedValue(TracedValue*, const char* name) const; 39 void toTracedValue(TracedValue*, const char* name) const;
38 PassOwnPtr<SourceLocation> clone() const; 40 PassOwnPtr<SourceLocation> clone() const;
39 41
40 private: 42 private:
41 SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber , std::unique_ptr<V8StackTrace>, int scriptId); 43 SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber , std::unique_ptr<V8StackTrace>, int scriptId);
42 44
43 String m_url; 45 String m_url;
44 unsigned m_lineNumber; 46 unsigned m_lineNumber;
45 unsigned m_columnNumber; 47 unsigned m_columnNumber;
46 std::unique_ptr<V8StackTrace> m_stackTrace; 48 std::unique_ptr<V8StackTrace> m_stackTrace;
47 int m_scriptId; 49 int m_scriptId;
48 }; 50 };
49 51
50 } // namespace blink 52 } // namespace blink
51 53
52 #endif // SourceLocation_h 54 #endif // SourceLocation_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698