Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2010593002: Revert of [keys] Simplify KeyAccumulator (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [keys] Simplify KeyAccumulator (patchset #15 id:280001 of https://codereview.chromium.org/1995263002/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/6248 Original issue's description: > [keys] Simplify KeyAccumulator > > - Use KeyAccumulator::GetKeys directly instead of JSReceiver::GetKeys > - Revert KeyAccumulator to single OrderedHashSet implementation. > - Convert the OrderedHashSet in-place to a FixedArray > - IndexedInterceptor indices are no longer combined and sorted with the object indices > > BUG= > > Committed: https://crrev.com/d3324df017046bcde247a5aef6d1b59bfae5908f > Cr-Commit-Position: refs/heads/master@{#36485} TBR=jkummerow@chromium.org,verwaest@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/893524b53d43df63bca6cb9b7244d21771fadb0b Cr-Commit-Position: refs/heads/master@{#36486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -304 lines) Patch
M src/api.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/builtins.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 12 chunks +52 lines, -68 lines 0 comments Download
M src/json-stringifier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/keys.h View 5 chunks +41 lines, -22 lines 0 comments Download
M src/keys.cc View 9 chunks +288 lines, -118 lines 0 comments Download
M src/objects.h View 2 chunks +11 lines, -4 lines 0 comments Download
M src/objects.cc View 5 chunks +13 lines, -37 lines 0 comments Download
M src/objects-inl.h View 3 chunks +11 lines, -20 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-forin.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M test/mjsunit/es6/reflect.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Achenbach
Created Revert of [keys] Simplify KeyAccumulator
4 years, 7 months ago (2016-05-24 17:35:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010593002/1
4 years, 7 months ago (2016-05-24 17:35:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 17:36:02 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/893524b53d43df63bca6cb9b7244d21771fadb0b Cr-Commit-Position: refs/heads/master@{#36486}
4 years, 7 months ago (2016-05-24 17:37:51 UTC) #5
Camillo Bruni
4 years, 7 months ago (2016-05-25 09:11:53 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2014523002/ by cbruni@chromium.org.

The reason for reverting is: relanding, fixed handle dereferencing.

Powered by Google App Engine
This is Rietveld 408576698