src/runtime/runtime-forin.cc - Issue 2010593002: Revert of [keys] Simplify KeyAccumulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-forin.cc

Issue 2010593002: Revert of [keys] Simplify KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-forin.cc

diff --git a/src/runtime/runtime-forin.cc b/src/runtime/runtime-forin.cc

index 6e73e36593f3943fca6c80392021f717f4628a93..1799b339e6b1b5c07406136dd29f6fb1af358ef0 100644

--- a/src/runtime/runtime-forin.cc

+++ b/src/runtime/runtime-forin.cc

@@ -25,7 +25,6 @@

FastKeyAccumulator accumulator(isolate, receiver, INCLUDE_PROTOS,

ENUMERABLE_STRINGS);

accumulator.set_filter_proxy_keys(false);

- accumulator.set_is_for_in(true);

// Test if we have an enum cache for {receiver}.

if (!accumulator.is_receiver_simple_enum()) {

Handle<FixedArray> keys;

« no previous file with comments | « src/runtime/runtime-array.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »