Check CallSite arguments more rigorously

Check CallSite arguments more rigorously

Before, it was possible to construct invalid CallSite objects, which
would trigger a runtime assert when any function is called on it.
This check ensures to throw a TypeError when invalid information is
passed to the CallSite constructor.

This reverts part of this CL: https://codereview.chromium.org/2006603002

R=ishell@chromium.org, titzer@chromium.org, yangguo@chromium.org
BUG=chromium:614295
Committed: https://crrev.com/25c2203a8f1553ac79deed299ff66830d4d9ec0e
Cr-Commit-Position: refs/heads/master@{#36578}

[Clemens Hammacher, 2016-05-24 10:49:35]

Description was changed from

==========
Check CallSite argument more rigorously

Before, it was possible to construct invalid CallSite objects, which
would trigger a runtime assert when any function is called on it.
This checks ensures to throw a TypeError when invalid information is
passed to the CallSite constructor.

This reverts part of this CL: https://codereview.chromium.org/2006603002

R=ishell@chromium.org, titzer@chromium.org, yangguo@chromium.org
BUG=chromium:614295
==========

to

==========
Check CallSite arguments more rigorously

Before, it was possible to construct invalid CallSite objects, which
would trigger a runtime assert when any function is called on it.
This check ensures to throw a TypeError when invalid information is
passed to the CallSite constructor.

This reverts part of this CL: https://codereview.chromium.org/2006603002

R=ishell@chromium.org, titzer@chromium.org, yangguo@chromium.org
BUG=chromium:614295
==========

[titzer, 2016-05-24 11:52:13]

On 2016/05/24 10:49:58, Clemens Hammacher wrote:

lgtm

[Yang, 2016-05-24 14:34:58]

On 2016/05/24 11:52:13, titzer wrote:
> On 2016/05/24 10:49:58, Clemens Hammacher wrote:
> 
> lgtm

lgtm.

[Igor Sheludko, 2016-05-25 08:26:30]

https://codereview.chromium.org/2010493002/diff/20001/src/messages.cc
File src/messages.cc (right):

https://codereview.chromium.org/2010493002/diff/20001/src/messages.cc#newcode181
src/messages.cc:181: if (!maybe_wasm_func_index->IsSmi()) {
What if we hit this case (for example if we pass a 0xffffffff as a function)?
Will we still hit the runtime assert?

[Clemens Hammacher, 2016-05-30 08:25:00]

https://codereview.chromium.org/2010493002/diff/20001/src/messages.cc
File src/messages.cc (right):

https://codereview.chromium.org/2010493002/diff/20001/src/messages.cc#newcode181
src/messages.cc:181: if (!maybe_wasm_func_index->IsSmi()) {
On 2016/05/25 08:26:29, Igor Sheludko wrote:
> What if we hit this case (for example if we pass a 0xffffffff as a function)?
> Will we still hit the runtime assert?

The private symbol "call_site_wasm_func_index_symbol" is only ever set from the
JS CallSite constructor, which checks that the input is valid for either
JavaScript or Wasm. So in this C++ function we do not need to check this again,
we just need to find out whether the JS constructor set the JS or Wasm fields.
IMO, a !IsUndefined() check would suffice here as well, but it would neither
improve runtime nor readability, so I would just keep it as is.

[Clemens Hammacher, 2016-05-30 10:25:03]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-05-30 10:25:04]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2010493002/#ps60001
(title: "add regression test case")

[commit-bot: I haz the power, 2016-05-30 10:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010493002/60001

[commit-bot: I haz the power, 2016-05-30 10:27:07]

Description was changed from

==========
Check CallSite arguments more rigorously

Before, it was possible to construct invalid CallSite objects, which
would trigger a runtime assert when any function is called on it.
This check ensures to throw a TypeError when invalid information is
passed to the CallSite constructor.

This reverts part of this CL: https://codereview.chromium.org/2006603002

R=ishell@chromium.org, titzer@chromium.org, yangguo@chromium.org
BUG=chromium:614295
==========

to

==========
Check CallSite arguments more rigorously

Before, it was possible to construct invalid CallSite objects, which
would trigger a runtime assert when any function is called on it.
This check ensures to throw a TypeError when invalid information is
passed to the CallSite constructor.

This reverts part of this CL: https://codereview.chromium.org/2006603002

R=ishell@chromium.org, titzer@chromium.org, yangguo@chromium.org
BUG=chromium:614295
==========

[commit-bot: I haz the power, 2016-05-30 10:27:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-30 10:30:18]

Description was changed from

==========
Check CallSite arguments more rigorously

Before, it was possible to construct invalid CallSite objects, which
would trigger a runtime assert when any function is called on it.
This check ensures to throw a TypeError when invalid information is
passed to the CallSite constructor.

This reverts part of this CL: https://codereview.chromium.org/2006603002

R=ishell@chromium.org, titzer@chromium.org, yangguo@chromium.org
BUG=chromium:614295
==========

to

==========
Check CallSite arguments more rigorously

Before, it was possible to construct invalid CallSite objects, which
would trigger a runtime assert when any function is called on it.
This check ensures to throw a TypeError when invalid information is
passed to the CallSite constructor.

This reverts part of this CL: https://codereview.chromium.org/2006603002

R=ishell@chromium.org, titzer@chromium.org, yangguo@chromium.org
BUG=chromium:614295

Committed: https://crrev.com/25c2203a8f1553ac79deed299ff66830d4d9ec0e
Cr-Commit-Position: refs/heads/master@{#36578}
==========

[commit-bot: I haz the power, 2016-05-30 10:30:19]

Patchset 4 (id:??) landed as
https://crrev.com/25c2203a8f1553ac79deed299ff66830d4d9ec0e
Cr-Commit-Position: refs/heads/master@{#36578}