Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2006603002: [runtime] Don't crash when trying to access manually constructed CallSite object. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Don't crash when trying to access manually constructed CallSite object. ... but hit the runtime assert instead. # # Runtime error in ../src/runtime/runtime-internal.cc, line 409 # # call_site.IsJavaScript() || call_site.IsWasm() # BUG=chromium:613905 LOG=N Committed: https://crrev.com/a7a14fdebcd686e89a6039d0d29b751c40b6027a Cr-Commit-Position: refs/heads/master@{#36430}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M src/messages.cc View 2 chunks +9 lines, -7 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-613905.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006603002/1
4 years, 7 months ago (2016-05-23 08:15:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006603002/20001
4 years, 7 months ago (2016-05-23 08:23:50 UTC) #5
Igor Sheludko
PTAL
4 years, 7 months ago (2016-05-23 08:24:34 UTC) #7
Yang
On 2016/05/23 08:24:34, Igor Sheludko wrote: > PTAL lgtm. thanks.
4 years, 7 months ago (2016-05-23 08:42:21 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 08:55:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006603002/20001
4 years, 7 months ago (2016-05-23 08:58:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-23 09:00:17 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 09:01:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7a14fdebcd686e89a6039d0d29b751c40b6027a
Cr-Commit-Position: refs/heads/master@{#36430}

Powered by Google App Engine
This is Rietveld 408576698