tools/metrics/histograms/histograms.xml - Issue 2010333004: Make file type MPKG generate a download ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2010333004: Make file type MPKG generate a download ping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix a SBClientDownload histogram type Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index d59435b60be62343cc4f1e68e004544bc3ae7800..0f41589dd1b2890de2c4ea895eaccf400ce058f2 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -46844,7 +46844,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

-<histogram name="SBClientDownload.DownloadRequestResponseCode">

+<histogram name="SBClientDownload.DownloadRequestResponseCode"

+ enum="HttpResponseCode">

<owner>mattm@chromium.org</owner>

For CheckClientDownloadRequest URLFetchers with successful status, the HTTP

@@ -47000,7 +47001,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

-<histogram name="SBClientMalware.IPBlacklistRequestResponseCode">

+<histogram name="SBClientMalware.IPBlacklistRequestResponseCode"

+ enum="HttpResponseCode">

<owner>noelutz@chromium.org</owner>

For ClientMalwareRequest URLFetchers with successful status, the HTTP

@@ -86000,6 +86002,7 @@ To add a new entry, add it with any value and run test to compute valid value.

+ <int value="263" label="MPKG"/>

</enum>

« no previous file with comments | « chrome/common/safe_browsing/download_protection_util.cc ('k') | no next file » | no next file with comments »