chrome/common/safe_browsing/download_protection_util.cc - Issue 2010333004: Make file type MPKG generate a download ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/download_protection_util.cc

Issue 2010333004: Make file type MPKG generate a download ping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix a SBClientDownload histogram type Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/safe_browsing/download_protection_util.cc

diff --git a/chrome/common/safe_browsing/download_protection_util.cc b/chrome/common/safe_browsing/download_protection_util.cc

index 25bb01bd6ad0d37ab70ad9095cefb2b4bcb10403..ba8a3afc5ca65d77dc83cf522a50f5a4f310733a 100644

--- a/chrome/common/safe_browsing/download_protection_util.cc

+++ b/chrome/common/safe_browsing/download_protection_util.cc

@@ -34,6 +34,7 @@ ClientDownloadRequest::DownloadType GetDownloadType(

file.MatchesExtension(FILE_PATH_LITERAL(".img")) ||

file.MatchesExtension(FILE_PATH_LITERAL(".iso")) ||

file.MatchesExtension(FILE_PATH_LITERAL(".pkg")) ||

+ file.MatchesExtension(FILE_PATH_LITERAL(".mpkg")) ||

file.MatchesExtension(FILE_PATH_LITERAL(".smi")) ||

file.MatchesExtension(FILE_PATH_LITERAL(".osx")) ||

file.MatchesExtension(FILE_PATH_LITERAL(".app")) ||