Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2010273002: Enables EXTERNAL_COMPONENT extensions in incognito by default. (Closed)

Created:
4 years, 6 months ago by mark a. foltz
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Enables EXTERNAL_COMPONENT extensions in incognito by default. Currently, the Media Router is in a broken state in incognito: it can talk to the component via the Mojo API, but access to resources (like the Cast SDK, feedbak, and setup) and tab capture is broken. This enables the component in incognito via the extensions system which resolves these issues. BUG=606495 Review-Url: https://codereview.chromium.org/1991263003 Cr-Commit-Position: refs/heads/master@{#395758} (cherry picked from commit 4193cc61735abc6d53edb85021222d5e866c2c6d) Committed: https://chromium.googlesource.com/chromium/src/+/4f9a72e8b1774a4eba32c2eb9adb6fe10479c2bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/extension_util.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
mark a. foltz
4 years, 6 months ago (2016-05-26 22:40:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f9a72e8b1774a4eba32c2eb9adb6fe10479c2bf.

Powered by Google App Engine
This is Rietveld 408576698