Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1991263003: Enables EXTERNAL_COMPONENT extensions in incognito by default. (Closed)

Created:
4 years, 7 months ago by mark a. foltz
Modified:
4 years, 7 months ago
Reviewers:
benwells
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enables EXTERNAL_COMPONENT extensions in incognito by default. Currently, the Media Router is in a broken state in incognito: it can talk to the component via the Mojo API, but access to resources (like the Cast SDK, feedbak, and setup) and tab capture is broken. This enables the component in incognito via the extensions system which resolves these issues. BUG=606495 Committed: https://crrev.com/4193cc61735abc6d53edb85021222d5e866c2c6d Cr-Commit-Position: refs/heads/master@{#395758}

Patch Set 1 #

Patch Set 2 : Include EXTERNAL_COMPONENTs as incognito #

Patch Set 3 : Revert tab_capture changes #

Total comments: 2

Patch Set 4 : Respond to benwells@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/extension_util.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
mark a. foltz
4 years, 7 months ago (2016-05-20 23:07:51 UTC) #4
benwells
This lg but the subject of the CL should match the first line of the ...
4 years, 7 months ago (2016-05-23 01:51:19 UTC) #5
mark a. foltz
Fixed description, PTAL https://codereview.chromium.org/1991263003/diff/40001/chrome/browser/extensions/extension_util.cc File chrome/browser/extensions/extension_util.cc (right): https://codereview.chromium.org/1991263003/diff/40001/chrome/browser/extensions/extension_util.cc#newcode130 chrome/browser/extensions/extension_util.cc:130: extension->location() == Manifest::EXTERNAL_COMPONENT) On 2016/05/23 at ...
4 years, 7 months ago (2016-05-23 22:08:13 UTC) #6
benwells
lgtm
4 years, 7 months ago (2016-05-24 01:43:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991263003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991263003/60001
4 years, 7 months ago (2016-05-24 23:21:28 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-25 00:56:07 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 00:57:44 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4193cc61735abc6d53edb85021222d5e866c2c6d
Cr-Commit-Position: refs/heads/master@{#395758}

Powered by Google App Engine
This is Rietveld 408576698