Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2010173004: [Mac/GN] Collect a bundle's data_deps when using `gn desc runtime_deps`. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Collect a bundle's data_deps when using `gn desc runtime_deps`. In 903e2b85c71675f83767ac9b1687087382b49f39, GN stopped recursing into bundles to collect target dependencies. But any explicit data_deps on a bundle should be included in the runtime_deps output. BUG=611414 R=brettw@chromium.org,sdefresne@chromium.org Committed: https://crrev.com/be4da4cd67c068e11bd226979faf1f578dae5a3f Cr-Commit-Position: refs/heads/master@{#396910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M tools/gn/runtime_deps.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/gn/runtime_deps_unittest.cc View 5 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Robert Sesek
4 years, 6 months ago (2016-05-27 20:52:03 UTC) #1
sdefresne
non-owners lgtm
4 years, 6 months ago (2016-05-28 13:19:00 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-05-31 18:58:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010173004/1
4 years, 6 months ago (2016-05-31 18:59:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 20:11:15 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/be4da4cd67c068e11bd226979faf1f578dae5a3f Cr-Commit-Position: refs/heads/master@{#396910}
4 years, 6 months ago (2016-05-31 20:45:04 UTC) #9
Dirk Pranke
On 2016/05/31 20:45:04, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 6 months ago (2016-05-31 20:49:22 UTC) #10
Robert Sesek
4 years, 6 months ago (2016-06-01 18:35:43 UTC) #11
Message was sent while issue was closed.
On 2016/05/31 20:49:22, Dirk Pranke wrote:
> Bah, I realized after the fact that we probably should've updated the docs for
> either `create_bundle` or `data_deps` or both to document this, since it's a
bit
> counter-intuitive otherwise.
> 
> Mind doing that in a follow-up CL?

https://codereview.chromium.org/2023003006

Powered by Google App Engine
This is Rietveld 408576698