Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2023003006: [Mac/iOS/GN] Document the new rules for create_bundle and runtime_deps. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/iOS/GN] Document the new rules for create_bundle and runtime_deps. BUG=611414 R=dpranke@chromium.org Committed: https://crrev.com/57979207f98a847a40a8f5b57633cf7427c68c28 Cr-Commit-Position: refs/heads/master@{#397258}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M tools/gn/docs/reference.md View 1 5 chunks +15 lines, -1 line 0 comments Download
M tools/gn/functions_target.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Robert Sesek
4 years, 6 months ago (2016-06-01 18:35:29 UTC) #1
Dirk Pranke
lgtm, but can you also update //tools/gn/docs/reference.md with the updated help? (Build GN itself, then ...
4 years, 6 months ago (2016-06-01 19:03:17 UTC) #2
Robert Sesek
On 2016/06/01 19:03:17, Dirk Pranke wrote: > lgtm, but can you also update //tools/gn/docs/reference.md with ...
4 years, 6 months ago (2016-06-01 19:34:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023003006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023003006/20001
4 years, 6 months ago (2016-06-01 21:34:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 21:40:54 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 21:42:23 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57979207f98a847a40a8f5b57633cf7427c68c28
Cr-Commit-Position: refs/heads/master@{#397258}

Powered by Google App Engine
This is Rietveld 408576698