third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp - Issue 2010103002: [Binding] [Refactoring] Remove redundant overloaded methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

Issue 2010103002: [Binding] [Refactoring] Remove redundant overloaded methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

index 569ce38aaf41a0e4fc9a1aba7d7e53d4eb880cb7..17af6d039dcd4d4d6263e848a3c02fc7c324324d 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

@@ -252,8 +252,10 @@ IDBRequest* IDBObjectStore::put(ScriptState* scriptState, WebIDBPutMode putMode,

return nullptr;

}

+ v8::Isolate* isolate = scriptState->isolate();

+ DCHECK(isolate->InContext());

Vector<WebBlobInfo> blobInfo;

- RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValueFactory::instance().create(scriptState->isolate(), value, &blobInfo, exceptionState);

+ RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValueFactory::instance().create(isolate, value.v8Value(), nullptr, &blobInfo, exceptionState);

if (exceptionState.hadException())

return nullptr;