third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp - Issue 2010103002: [Binding] [Refactoring] Remove redundant overloaded methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

Issue 2010103002: [Binding] [Refactoring] Remove redundant overloaded methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/methods.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

index 365c5dad592b1d5c4f6bf5d3a5c6ac7575c8cce2..f2c8f97a45d6406baca0bc503ba5b147c621fc7c 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

@@ -1046,7 +1046,7 @@ static void serializedScriptValueAttributeAttributeSetter(v8::Local<v8::Value> v

v8::Local<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "serializedScriptValueAttribute", "TestObject", holder, info.GetIsolate());

TestObject* impl = V8TestObject::toImpl(holder);

- RefPtr<SerializedScriptValue> cppValue = SerializedScriptValueFactory::instance().create(info.GetIsolate(), v8Value, nullptr, exceptionState);

+ RefPtr<SerializedScriptValue> cppValue = SerializedScriptValueFactory::instance().create(info.GetIsolate(), v8Value, nullptr, nullptr, exceptionState);

if (exceptionState.throwIfNeeded())

return;

impl->setSerializedScriptValueAttribute(cppValue);

@@ -7049,7 +7049,7 @@ static void voidMethodSerializedScriptValueArgMethod(const v8::FunctionCallbackI

TestObject* impl = V8TestObject::toImpl(info.Holder());

RefPtr<SerializedScriptValue> serializedScriptValueArg;

{

- serializedScriptValueArg = SerializedScriptValueFactory::instance().create(info.GetIsolate(), info[0], nullptr, exceptionState);

+ serializedScriptValueArg = SerializedScriptValueFactory::instance().create(info.GetIsolate(), info[0], nullptr, nullptr, exceptionState);

if (exceptionState.throwIfNeeded())

return;

}

@@ -10160,7 +10160,7 @@ void postMessageImpl(const char* interfaceName, TestObject* instance, const v8::

return;

}

- RefPtr<SerializedScriptValue> message = SerializedScriptValueFactory::instance().create(info.GetIsolate(), info[0], &transferables, exceptionState);

+ RefPtr<SerializedScriptValue> message = SerializedScriptValueFactory::instance().create(info.GetIsolate(), info[0], &transferables, nullptr, exceptionState);

if (exceptionState.throwIfNeeded())

return;

// FIXME: Only pass context/exceptionState if instance really requires it.