Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: ui/views/mus/BUILD.gn

Issue 2010083002: views/mus: Run some more tests from views_unittests in mus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/mus/BUILD.gn
diff --git a/ui/views/mus/BUILD.gn b/ui/views/mus/BUILD.gn
index 065d32ca15106d6bbc0083bf568c06714c0a6923..943cf8370f542e6bf1d510e9680d9681400bc965 100644
--- a/ui/views/mus/BUILD.gn
+++ b/ui/views/mus/BUILD.gn
@@ -9,6 +9,10 @@ import("//mojo/public/mojo_application_manifest.gni")
import("//testing/test.gni")
import("//tools/grit/repack.gni")
+gypi = exec_script("//build/gypi_to_gn.py",
+ [ rebase_path("../views.gyp") ],
+ "scope",
+ [ "../views.gyp" ])
component("mus") {
output_name = "ui_views_mus_lib"
@@ -126,8 +130,6 @@ source_set("test_support") {
sources = [
"../test/native_widget_factory_mus.cc",
- "../views_test_suite.cc",
- "../views_test_suite.h",
"views_mus_test_suite.cc",
"views_mus_test_suite.h",
]
@@ -159,16 +161,7 @@ test("views_mus_unittests") {
configs += [ "//build/config:precompiled_headers" ]
- # TODO(sky): add more files.
sources = [
- "../controls/native/native_view_host_aura_unittest.cc",
- "../controls/native/native_view_host_test_base.cc",
- "../controls/native/native_view_host_test_base.h",
- "../controls/native/native_view_host_unittest.cc",
- "../view_targeter_unittest.cc",
- "../widget/native_widget_aura_unittest.cc",
- "../widget/native_widget_unittest.cc",
- "../widget/widget_unittest.cc",
"display_list_unittest.cc",
"native_widget_mus_unittest.cc",
"run_all_unittests_mus.cc",
@@ -176,11 +169,30 @@ test("views_mus_unittests") {
"window_manager_connection_unittest.cc",
]
+ sources += rebase_path(gypi.views_unittests_sources, ".", "//ui/views")
+ sources += rebase_path(gypi.views_unittests_aura_sources, ".", "//ui/views")
+
+ sources -= [
+ # Mus has its own runner.
+ "../run_all_unittests_main.cc",
+
+ # EventGenerator doesn't work well with IME in mus.
+ # crbug.com/615033 crbug.com/548407
+ "../controls/textfield/textfield_unittest.cc",
+
+ # Tooltips. crbug.com/599558
+ "../corewm/tooltip_controller_unittest.cc",
+
+ # Some of the tests need drag-drop support. crbug.com/614037
+ "../touchui/touch_selection_controller_impl_unittest.cc",
+ ]
+
deps = [
":mus",
":test_support",
"//base",
"//base:i18n",
+ "//base/test:test_support",
"//cc",
"//components/mus/public/cpp",
"//components/mus/public/cpp/tests:unittest_support",
@@ -202,7 +214,9 @@ test("views_mus_unittests") {
"//ui/events/platform",
"//ui/gfx:test_support",
"//ui/gfx/geometry",
+ "//ui/native_theme",
"//ui/strings",
+ "//ui/touch_selection",
"//ui/views",
"//ui/views:test_support_internal",
"//ui/wm",

Powered by Google App Engine
This is Rietveld 408576698