Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: ui/views/focus/focus_manager_unittest.cc

Issue 2010083002: views/mus: Run some more tests from views_unittests in mus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/focus/focus_manager_unittest.cc
diff --git a/ui/views/focus/focus_manager_unittest.cc b/ui/views/focus/focus_manager_unittest.cc
index c37b77f2822b2796db40ec207131b69bf8799bc4..755c141441861556b6defde5271c117a0e834ab9 100644
--- a/ui/views/focus/focus_manager_unittest.cc
+++ b/ui/views/focus/focus_manager_unittest.cc
@@ -123,6 +123,9 @@ TEST_F(FocusManagerTest, FocusChangeListener) {
}
TEST_F(FocusManagerTest, WidgetFocusChangeListener) {
+ // SimulateNativeActive() doesn't work correctly in mus.
sky 2016/06/08 04:25:02 I recommend NOTIMPLEMENTEDs and filing bugs for al
sadrul 2016/06/08 14:57:42 Ended up fixing this particular test in https://co
+ if (IsMus())
+ return;
// First, ensure the simulator is aware of the Widget created in SetUp() being
// currently active.
test::WidgetTest::SimulateNativeActivate(GetWidget());
@@ -866,6 +869,9 @@ class AdvanceFocusWidgetDelegate : public WidgetDelegate {
// Verifies focus wrapping happens in the same widget.
TEST_F(FocusManagerTest, AdvanceFocusStaysInWidget) {
+ // Mus doesn't support child Widgets well yet. https://crbug.com/612820
+ if (IsMus())
+ return;
// Add |widget_view| as a child of the Widget.
View* widget_view = new View;
widget_view->SetFocusBehavior(View::FocusBehavior::ALWAYS);

Powered by Google App Engine
This is Rietveld 408576698