[Mac] Fixes janky animations in the omnibox popup....

[Mac] Fixes janky animations in the omnibox popup.

BUG=None
TEST=Hold down 'a' in the omnibox.  The animation should be smooth and not flickery.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46632

[Scott Hess - ex-Googler, 2010-05-06 20:00:02]

LGTM, with moving more into SetPopupFrame().

The test change non-blocking, just a suggestion.

http://codereview.chromium.org/2010002/diff/1/2
File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (right):

http://codereview.chromium.org/2010002/diff/1/2#newcode399
chrome/browser/autocomplete/autocomplete_popup_view_mac.mm:399: r.size.width ==
currentPopupFrame.size.width);
I would push all of this into SetPopupFrame().

I think this test can be simplified:
  (NSWidth(r) == NSWidth(current) && NSContainsRect(current, r))
I think the only way x can change is if the window is moved, which should be
handled by the popup being a child window.  SetPopupFrame() is checking for
equal, so "contains" means that it is strictly smaller.  The width can still
change if the parent window is resized.

[rohitrao (ping after 24h), 2010-05-06 20:16:33]

I moved the test into SetPopupFrame().  I'm hesitant to change the test, because
I have this vague feeling that it's written that way for a reason, but I don't
remember what it is.  I'll dig into it more after submitting.

[Scott Hess - ex-Googler, 2010-05-06 20:27:45]

lgtm