Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Cleaning up audio-data*, audio-garbage* and audio-play* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/b7181764cf5da42aa606b814291c9a465567461b
Cr-Commit-Position: refs/heads/master@{#396266}

[Srirama, 2016-05-26 14:58:40]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Cleaning up audio-data*, audio-garbage* and audio-play* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

[Srirama, 2016-05-26 14:58:59]

Description was changed from

==========
Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Cleaning up audio-data*, audio-garbage* and audio-play* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

to

==========
Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Cleaning up audio-data*, audio-garbage* and audio-play* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

[Srirama, 2016-05-26 15:07:04]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-05-26 15:07:10]

Patchset #2 (id:40001) has been deleted

[Srirama, 2016-05-26 15:09:50]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-05-26 15:09:50]

https://codereview.chromium.org/2009993003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/audio-play-event.html (right):

https://codereview.chromium.org/2009993003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/audio-play-event.html:9: audio.onplay =
t.step_func_done();
Should we test playing event as well? Based on the title, I removed all other
events.

[fs, 2016-05-26 15:35:00]

https://codereview.chromium.org/2009993003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/audio-play-event.html (right):

https://codereview.chromium.org/2009993003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/audio-play-event.html:9: audio.onplay =
t.step_func_done();
On 2016/05/26 at 15:09:50, Srirama wrote:
> Should we test playing event as well? Based on the title, I removed all other
events.

Can't say that I fully understand the reasoning behind this test setup, but
erring on the side of caution and doing step_func and unreached_func for the
other events listed at least won't hurt.

[Srirama, 2016-05-26 17:27:51]

https://codereview.chromium.org/2009993003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/audio-play-event.html (right):

https://codereview.chromium.org/2009993003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/audio-play-event.html:9: audio.onplay =
t.step_func_done();
On 2016/05/26 15:35:00, fs wrote:
> On 2016/05/26 at 15:09:50, Srirama wrote:
> > Should we test playing event as well? Based on the title, I removed all
other
> events.
> 
> Can't say that I fully understand the reasoning behind this test setup, but
> erring on the side of caution and doing step_func and unreached_func for the
> other events listed at least won't hurt.

Done.

[Srirama, 2016-05-26 17:39:32]

https://codereview.chromium.org/2009993003/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/audio-play-event.html (right):

https://codereview.chromium.org/2009993003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/audio-play-event.html:11: eventCount++;
Should i reset each event to null so that it won't fire again and disturb the
event count

[fs, 2016-05-26 18:29:21]

https://codereview.chromium.org/2009993003/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/audio-play-event.html (right):

https://codereview.chromium.org/2009993003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/audio-play-event.html:11: eventCount++;
On 2016/05/26 at 17:39:32, Srirama wrote:
> Should i reset each event to null so that it won't fire again and disturb the
event count

If there were risk of seeing the same event twice for the duration of the test,
then yes. I don't think that is the case here though? I'm not sure eventCount is
strictly needed, empty step functions ought to work equally well I think.

[Srirama, 2016-05-26 18:54:29]

https://codereview.chromium.org/2009993003/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/audio-play-event.html (right):

https://codereview.chromium.org/2009993003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/audio-play-event.html:11: eventCount++;
On 2016/05/26 18:29:21, fs wrote:
> On 2016/05/26 at 17:39:32, Srirama wrote:
> > Should i reset each event to null so that it won't fire again and disturb
the
> event count
> 
> If there were risk of seeing the same event twice for the duration of the
test,
> then yes. I don't think that is the case here though? I'm not sure eventCount
is
> strictly needed, empty step functions ought to work equally well I think.

Done.

[fs, 2016-05-26 18:56:32]

lgtm

[Srirama, 2016-05-26 18:57:00]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-05-26 18:57:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009993003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009993003/80001

[commit-bot: I haz the power, 2016-05-26 20:10:52]

Description was changed from

==========
Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Cleaning up audio-data*, audio-garbage* and audio-play* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

to

==========
Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Cleaning up audio-data*, audio-garbage* and audio-play* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

[commit-bot: I haz the power, 2016-05-26 20:10:53]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-05-26 20:12:25]

Description was changed from

==========
Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Cleaning up audio-data*, audio-garbage* and audio-play* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

to

==========
Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Cleaning up audio-data*, audio-garbage* and audio-play* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/b7181764cf5da42aa606b814291c9a465567461b
Cr-Commit-Position: refs/heads/master@{#396266}
==========

[commit-bot: I haz the power, 2016-05-26 20:12:27]

Patchset 3 (id:??) landed as
https://crrev.com/b7181764cf5da42aa606b814291c9a465567461b
Cr-Commit-Position: refs/heads/master@{#396266}