third_party/WebKit/LayoutTests/media/audio-play-event.html - Issue 2009993003: Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/audio-play-event.html

Issue 2009993003: Convert audio-data*, audio-garbage* and audio-play* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/audio-garbage-collect-expected.txt ('k') | third_party/WebKit/LayoutTests/media/audio-play-event-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <!DOCTYPE HTML>

2 <head>	2 <title>Test that a 'play' event is fired by a new audio element on playing.</tit le>

3 <title>'play' event</title>	3 <script src="media-file.js"></script>

4 <script src=media-file.js></script>	4 <script src="../resources/testharness.js"></script>

5 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	5 <script src="../resources/testharnessreport.js"></script>

6 (Please avoid writing new tests using video-test.js) -->	6 <script>

7 <script src=video-test.js></script>	7 async_test(function(t) {

8	8 var eventCount = 0;

9 <script>	9 var audio = new Audio();

10 function start()	10 audio.onplay = t.step_func(function() {

11 {	11 eventCount++;
	Srirama 2016/05/26 17:39:32 Should i reset each event to null so that it won't Should i reset each event to null so that it won't fire again and disturb the event count fs 2016/05/26 18:29:21 If there were risk of seeing the same event twice Show quoted text On 2016/05/26 at 17:39:32, Srirama wrote: > Should i reset each event to null so that it won't fire again and disturb the event count If there were risk of seeing the same event twice for the duration of the test, then yes. I don't think that is the case here though? I'm not sure eventCount is strictly needed, empty step functions ought to work equally well I think. Srirama 2016/05/26 18:54:29 Done. Show quoted text On 2016/05/26 18:29:21, fs wrote: > On 2016/05/26 at 17:39:32, Srirama wrote: > > Should i reset each event to null so that it won't fire again and disturb the > event count > > If there were risk of seeing the same event twice for the duration of the test, > then yes. I don't think that is the case here though? I'm not sure eventCount is > strictly needed, empty step functions ought to work equally well I think. Done.
12 mediaElement = new Audio();	12 });

13 waitForEvent('error');	13 audio.onloadedmetadata = t.step_func(function() {

14 waitForEvent('loadedmetadata');	14 eventCount++;

15 waitForEvent('canplay');	15 });

16 waitForEvent('play');	16 audio.oncanplay = t.step_func(function() {

17 waitForEvent('playing', function() { endTest(); });	17 eventCount++;

18 run("mediaElement.src = findMediaFile('audio', 'content/test')") ;	18 });

19 run("mediaElement.volume = 1");	19 audio.onplaying = t.step_func_done(function() {

20 run("mediaElement.play()");	20 assert_equals(eventCount, 3);

21 }	21 });

22 </script>	22 audio.onerror = t.unreached_func("Should not fire 'error' event");

23 </head>	23 audio.src = findMediaFile("audio", "content/test");

24	24 audio.play();

25 <body onload="start()">	25 });

26 <p>Test that a 'play' event listener is triggered when fired by a new audio element.</p>	26 </script>

27 </body>

28 </html>

OLD	NEW