[modules] Disable HTML-like comments

src/parsing/scanner.h

Index: src/parsing/scanner.h
diff --git a/src/parsing/scanner.h b/src/parsing/scanner.h
index 0acc7ab019a1c7e033ec9160d905990b4419b1bf..bb734494f9ee5234e7177e95d6a49a4e4a0e3b3c 100644
--- a/src/parsing/scanner.h
+++ b/src/parsing/scanner.h
@@ -474,6 +474,8 @@ class Scanner {
 
   bool FoundHtmlComment() const { return found_html_comment_; }
 
+  void set_allow_html_comments(bool allow) { allow_html_comments_ = allow; }
+
 #define DECLARE_ACCESSORS(name)                                \
   inline bool allow_##name() const { return allow_##name##_; } \
   inline void set_allow_##name(bool allow) { allow_##name##_ = allow; }
@@ -804,6 +806,9 @@ class Scanner {
   // Whether this scanner encountered an HTML comment.
   bool found_html_comment_;
 
+  // Whether this scanner should recognize HTML-like comment tokens.

[vogelheim, 2016/05/27 08:08:49]

Please be clear on what this does.

As I read the code,
- allow_html_comments_ == true means that an HTML comment will be reported as
individual tokens (and thus usually as syntax error), while
- !allow_html_comments_ means the current behaviour, namely that HTML comments
will be recognized & skipped.

I would have assumed it to be the other way round... In either case, the comment
doesn't really clarify this.

[mike3, 2016/05/27 15:53:22]

Yes, you are right. I'm afraid I applied Adam's feedback thoughtlessly by simply
re-naming the variable I had initially called `module_`. Changing to
`allow_html_comments_` obviously inverts the semantic meaning of the flag, so I
need to update its usage accordingly.

+  bool allow_html_comments_;
+
   bool allow_harmony_exponentiation_operator_;
 
   MessageTemplate::Template scanner_error_;