[modules] Disable HTML-like comments

src/parsing/scanner.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Features shared by parsing and pre-parsing scanners.
 
 #ifndef V8_PARSING_SCANNER_H_
 #define V8_PARSING_SCANNER_H_
 
 #include "src/allocation.h"
@@ skipping 456 matching lines @@
 
   const LiteralBuffer* source_url() const { return &source_url_; }
   const LiteralBuffer* source_mapping_url() const {
     return &source_mapping_url_;
   }
 
   bool IdentifierIsFutureStrictReserved(const AstRawString* string) const;
 
   bool FoundHtmlComment() const { return found_html_comment_; }
 
+  void set_allow_html_comments(bool allow) { allow_html_comments_ = allow; }
+
 #define DECLARE_ACCESSORS(name)                                \
   inline bool allow_##name() const { return allow_##name##_; } \
   inline void set_allow_##name(bool allow) { allow_##name##_ = allow; }
   DECLARE_ACCESSORS(harmony_exponentiation_operator)
 #undef ACCESSOR
 
  private:
   // The current and look-ahead token.
   struct TokenDesc {
     Token::Value token;
@@ skipping 310 matching lines @@
   // inside multiline comments.
   bool has_line_terminator_before_next_;
   // Whether there is a multi-line comment that contains a
   // line-terminator after the current token, and before the next.
   bool has_multiline_comment_before_next_;
   bool has_line_terminator_after_next_;
 
   // Whether this scanner encountered an HTML comment.
   bool found_html_comment_;
 
+  // Whether this scanner should recognize HTML-like comment tokens.

[vogelheim, 2016/05/27 08:08:49]

Please be clear on what this does.

As I read the code,
- allow_html_comments_ == true means that an HTML comment will be reported as
individual tokens (and thus usually as syntax error), while
- !allow_html_comments_ means the current behaviour, namely that HTML comments
will be recognized & skipped.

I would have assumed it to be the other way round... In either case, the comment
doesn't really clarify this.

[mike3, 2016/05/27 15:53:22]

Yes, you are right. I'm afraid I applied Adam's feedback thoughtlessly by simply
re-naming the variable I had initially called `module_`. Changing to
`allow_html_comments_` obviously inverts the semantic meaning of the flag, so I
need to update its usage accordingly.

+  bool allow_html_comments_;
+
   bool allow_harmony_exponentiation_operator_;
 
   MessageTemplate::Template scanner_error_;
   Location scanner_error_location_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_PARSING_SCANNER_H_