Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2009813004: Enable chromium_code standard for XFA code (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Enable chromium_code standard for XFA code Clean up the left code which causes warnings. Enable using chromium_code for XFA compilation, also re-enable all the msvs warning flags except 4267 (same as the main pdfium code). BUG=pdfium:29, pdfium:475 Committed: https://pdfium.googlesource.com/pdfium/+/60607c3baaf52574cab748a97c213e447c9108c0

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -17 lines) Patch
M xfa.gyp View 3 chunks +5 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_widgetmgr.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 3 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Wei Li
for review, thanks
4 years, 7 months ago (2016-05-26 18:22:24 UTC) #3
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-26 18:24:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009813004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009813004/40001
4 years, 7 months ago (2016-05-26 18:38:00 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:53:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/60607c3baaf52574cab748a97c213e447c91...

Powered by Google App Engine
This is Rietveld 408576698