Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: xfa.gyp

Issue 2009813004: Enable chromium_code standard for XFA code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_widgetmgr.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa.gyp
diff --git a/xfa.gyp b/xfa.gyp
index a4a6247694a79c802d7cae806eaf4702e33c2a19..ead79d3c1556f8d7635b2747bf4f634f4b40402e 100644
--- a/xfa.gyp
+++ b/xfa.gyp
@@ -1,5 +1,6 @@
{
"variables": {
+ "chromium_code": 1,
"pdf_enable_v8%": 1,
},
"target_defaults": {
@@ -7,9 +8,7 @@
"PDF_ENABLE_XFA",
],
'msvs_disabled_warnings': [
- 4005, 4018, 4146, 4333, 4345, 4267,
- # TODO(thestig): Fix all instances, remove this, pdfium:29
- 4245, 4310, 4389, 4701, 4702, 4706, 4800,
+ 4267,
],
},
"targets":[
@@ -699,6 +698,9 @@
"conditions": [
["clang==1" , {
}],
+ ["os_posix==1 and clang==0", { # When GCC
+ 'cflags': [ '-Wno-error=strict-overflow' ],
+ }],
["pdf_enable_v8==1", {
'dependencies': [
'<(DEPTH)/v8/src/v8.gyp:v8',
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_widgetmgr.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698