Revert of Implement DISALLOW_COPY_AND_ASSIGN using = delete.

Revert of Implement DISALLOW_COPY_AND_ASSIGN using = delete. (patchset #28 id:540001 of https://codereview.chromium.org/1981053002/ )

Reason for revert:
This causes compile errors on some bots (e.g. https://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder&number=40216)

Original issue's description:
> Implement DISALLOW_COPY_AND_ASSIGN using = delete.
>
> BUG=447156
> TEST=none
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=rdevlin.cronin
>
> Committed: https://crrev.com/16afbf1fd62d6d4d4cf34c148333bd5b7aaf997f
> Cr-Commit-Position: refs/heads/master@{#395814}

TBR=thakis@chromium.org,hcarmona@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org,pkasting@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447156
Committed: https://crrev.com/449883eb67fb8e0a3b3325682d2db4a16f1cdbed
Cr-Commit-Position: refs/heads/master@{#395825}

[hajimehoshi, 2016-05-25 07:44:17]

Created Revert of Implement DISALLOW_COPY_AND_ASSIGN using = delete.

[commit-bot: I haz the power, 2016-05-25 07:44:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009783002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009783002/1

[commit-bot: I haz the power, 2016-05-25 07:45:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-25 07:46:41]

Description was changed from

==========
Revert of Implement DISALLOW_COPY_AND_ASSIGN using = delete. (patchset #28
id:540001 of https://codereview.chromium.org/1981053002/ )

Reason for revert:
This causes compile errors on some bots (e.g.
https://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20...)

Original issue's description:
> Implement DISALLOW_COPY_AND_ASSIGN using = delete.
> 
> BUG=447156
> TEST=none
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=rdevlin.cronin
> 
> Committed: https://crrev.com/16afbf1fd62d6d4d4cf34c148333bd5b7aaf997f
> Cr-Commit-Position: refs/heads/master@{#395814}

TBR=thakis@chromium.org,hcarmona@chromium.org,lazyboy@chromium.org,rdevlin.cr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447156
==========

to

==========
Revert of Implement DISALLOW_COPY_AND_ASSIGN using = delete. (patchset #28
id:540001 of https://codereview.chromium.org/1981053002/ )

Reason for revert:
This causes compile errors on some bots (e.g.
https://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20...)

Original issue's description:
> Implement DISALLOW_COPY_AND_ASSIGN using = delete.
>
> BUG=447156
> TEST=none
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=rdevlin.cronin
>
> Committed: https://crrev.com/16afbf1fd62d6d4d4cf34c148333bd5b7aaf997f
> Cr-Commit-Position: refs/heads/master@{#395814}

TBR=thakis@chromium.org,hcarmona@chromium.org,lazyboy@chromium.org,rdevlin.cr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447156

Committed: https://crrev.com/449883eb67fb8e0a3b3325682d2db4a16f1cdbed
Cr-Commit-Position: refs/heads/master@{#395825}
==========

[commit-bot: I haz the power, 2016-05-25 07:46:42]

Patchset 1 (id:??) landed as
https://crrev.com/449883eb67fb8e0a3b3325682d2db4a16f1cdbed
Cr-Commit-Position: refs/heads/master@{#395825}

[Nico, 2016-05-25 13:29:51]

i'd recommend relanding this on some platforms first (say, linux) so that the cq
will make sure shared code doesn't regress

[Peter Kasting, 2016-05-25 18:56:49]

On 2016/05/25 13:29:51, Nico wrote:
> i'd recommend relanding this on some platforms first (say, linux) so that the
cq
> will make sure shared code doesn't regress

That's not actually going to make my life much better.  It's simply a matter of
being able to land immediately after a clean try run here.

[Nico, 2016-05-25 19:25:31]

No, since the cq doesn't check all possible configs (think eg official
builds)
On May 25, 2016 2:56 PM, <pkasting@chromium.org> wrote:

> On 2016/05/25 13:29:51, Nico wrote:
> > i'd recommend relanding this on some platforms first (say, linux) so
> that the
> cq
> > will make sure shared code doesn't regress
>
> That's not actually going to make my life much better. It's simply a
> matter of
> being able to land immediately after a clean try run here.
>
> https://codereview.chromium.org/2009783002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.