Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: device/bluetooth/bluetooth_low_energy_win.cc

Issue 2009753002: bluetooth: Make public BluetoothDevice::GetName method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge TOT Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_low_energy_win.cc
diff --git a/device/bluetooth/bluetooth_low_energy_win.cc b/device/bluetooth/bluetooth_low_energy_win.cc
index b96277c18304793884ede9fdf120e52dde686a4e..51485992e62969cad63f822a1c99a1b7e8bf6167 100644
--- a/device/bluetooth/bluetooth_low_energy_win.cc
+++ b/device/bluetooth/bluetooth_low_energy_win.cc
@@ -467,14 +467,8 @@ bool CollectBluetoothLowEnergyDeviceInfo(
device_info_handle, &device_info_data, result, error)) {
return false;
}
- if (!CollectBluetoothLowEnergyDeviceFriendlyName(
- device_info_handle, &device_info_data, result, error)) {
- // Only fail if not the GATT service device interface, which doesn't have a
- // friendly name.
- if (device_interface_data->InterfaceClassGuid !=
ortuno 2016/07/14 21:11:41 Hmm this would mean that we no longer fail if we c
scheib 2016/07/16 00:21:36 Acknowledged, would be great to know if we'd alway
- GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE)
- return false;
- }
+ CollectBluetoothLowEnergyDeviceFriendlyName(device_info_handle,
+ &device_info_data, result, error);
if (!CollectBluetoothLowEnergyDeviceAddress(
device_info_handle, &device_info_data, result, error)) {
return false;

Powered by Google App Engine
This is Rietveld 408576698